This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
Aggregate PoRep #1381
Merged
Aggregate PoRep #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1381 +/- ##
========================================
- Coverage 64.9% 64.3% -0.7%
========================================
Files 81 81
Lines 8197 8287 +90
========================================
+ Hits 5328 5333 +5
- Misses 1977 2062 +85
Partials 892 892 |
11 tasks
This was referenced Mar 17, 2021
ZenGround0
force-pushed
the
spike/aggregate-porep
branch
from
b3317b8
to
365e1e4
Compare
ZenGround0
force-pushed
the
spike/aggregate-porep
branch
from
365e1e4
to
f4b3651
Compare
Codecov Report
@@ Coverage Diff @@
## master #1381 +/- ##
========================================
- Coverage 69.6% 69.6% -0.1%
========================================
Files 72 72
Lines 7690 7795 +105
========================================
+ Hits 5356 5429 +73
- Misses 1443 1465 +22
- Partials 891 901 +10 |
ZenGround0
force-pushed
the
spike/aggregate-porep
branch
from
af22667
to
81c5bff
Compare
anorth
reviewed
May 11, 2021
anorth
suggested changes
May 11, 2021
| }}, | ||
| {To: builtin.StorageMarketActorAddr, Method: builtin.MethodsMarket.CronTick}, | ||
| }, | ||
| }.Matches(t, v.Invocations()[1]) |
There was a problem hiding this comment.
I would say this whole "check nothing in cron" is overkill here.
7 tasks
Merged
anorth
approved these changes
May 13, 2021
ZenGround0
force-pushed
the
spike/aggregate-porep
branch
from
4aaaf11
to
e638752
Compare
1 task
anorth
reviewed
May 14, 2021
actors/builtin/miner/miner_actor.go
Outdated
| @@ -74,6 +74,7 @@ func (a Actor) Exports() []interface{} { | |||
| 22: a.RepayDebt, | |||
| 23: a.ChangeOwnerAddress, | |||
| 24: a.DisputeWindowedPoSt, | |||
| 25: a.ProveCommitAggregate, | |||
There was a problem hiding this comment.
@ZenGround0 you'll need to rebase against the new method in #1407, now landed.
ZenGround0
force-pushed
the
spike/aggregate-porep
branch
from
f1bfede
to
f41487f
Compare
- ProveCommitAggregate - Update syscalls - Scenario tests for measuring aggregate vs current porep - Batch inputs to ComputeDataCommitment - MaxProveCommitDuration 1 day => 6 days
ZenGround0
force-pushed
the
spike/aggregate-porep
branch
from
f41487f
to
5f76287
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes needed for introducing aggregate porep verification into the network.
ProveCommitAggregateProveCommitandProveCommitAggregateto measure gas costsComputeDataCommitmentcall to save gasComputeDataCommitmenttestingProveCommitAggreagateto retain safety properties protecting against programmer error in deadline codeAccurate gas tableFinal min and max aggregate batch parameters and max proof size parameterProveCommitAggregate--edit--
I'm calling final Gas and param estimation out of scope because we'll need to merge this into lotus to start gas rebalancing. We will do the final parameter setting in another PR.
Closes #1257.