This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
Adjust code for subtle change in go-multihash 0.0.15 #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdan
approved these changes
Jun 30, 2021
Stebalien
approved these changes
Jun 30, 2021
|
This updates a dependency, so please don't merge until we've cut a v6 branch. |
This comment has been minimized.
This comment has been minimized.
|
Pushed to chore/upgrade_go-multihash |
Codecov Report
@@ Coverage Diff @@
## master #1463 +/- ##
======================================
Coverage 70.2% 70.2%
======================================
Files 72 72
Lines 7802 7802
======================================
Hits 5481 5481
Misses 1438 1438
Partials 883 883 |
marten-seemann
approved these changes
Jun 30, 2021
@Stebalien I just realized I do not need to do any of the version bumps. The diff in this PR at the time of writing is sufficient to allow |
Stebalien
approved these changes
Jul 22, 2021
|
Merging because this is a testing only change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-multihash is now wrapping the returned error, so the check in the test lib requires an
errors.Ishttps://github.com/multiformats/go-multihash/blob/v0.0.15/core/registry.go#L58-L60
cc @warpfork @mvdan