Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update poseidon.md - Filecoin spec has a minor typo #1318

Merged
merged 3 commits into from
Jul 16, 2023

Conversation

flipdazed
Copy link
Contributor

@flipdazed flipdazed commented Mar 27, 2023

There’s a minor error in filecoin paper

calc_round_numbers(p,M,t,α) is a typo… It does not receive alpha as final parameters it receives $c_{\alpha} \in {0, 1, 2}$

As per the source code

if sbox_case == 0:
    print "S-box: f(x) = x^3"
elif sbox_case == 1:
    print "S-box: f(x) = x^5"
elif sbox_case == 2:
    print "S-box: f(x) = x^(-1)"

It’s quite obvious so idk if anyone cares - maybe it was updated since the spec was written...?

There’s a minor error in filecoin paper

`calc_round_numbers(p,M,t,α)` is a typo… It does not receive alpha as final parameters it receives $c_{\alpha} \in {0, 1, 2}$
```
if sbox_case == 0:
    print "S-box: f(x) = x^3"
elif sbox_case == 1:
    print "S-box: f(x) = x^5"
elif sbox_case == 2:
    print "S-box: f(x) = x^(-1)"
```
It’s quite obvious so idk if anyone cares
@smagdali smagdali self-assigned this Jul 14, 2023
@smagdali smagdali requested review from smagdali and removed request for DrPeterVanNostrand July 14, 2023 12:23
@smagdali smagdali closed this Jul 14, 2023
@smagdali smagdali reopened this Jul 14, 2023
@smagdali smagdali merged commit 30aab19 into filecoin-project:master Jul 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants