A smattering of commits to get the build / deploy flow working again #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianconsolata
force-pushed
the
id/redeploy
branch
from
ddb49d6
to
7fdb7b1
Compare
The build breaks when minified, but works fine without it. This shoud be re-enabled later, nut for now I just want to get this site building again.
These files are very hard to generate via CI because they require puppeteer, but easy to generate locally. Eventually this should be re-enabled in CI
|
@cwaring got things building in Fleek again. Can you review and merge this so I can start clearing out the backlog of other PRs? |
Closed
johnnymatthews
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
Nice job clearing this repo up @ianconsolata! It's been borked since 2021!
cwaring
previously approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hodgepodge of updates and changes I needed to make in order to get the project building again. None of them had major substantive changes, except that I had to disable minification. The non-minified build works fine, however, so for now just use the non-minified version so we can start making updates again.