Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest go-fil-markets w/ enhanced Graphsync #3978

Merged
merged 3 commits into from
Apr 22, 2020

Conversation

hannahhoward
Copy link
Contributor

@hannahhoward hannahhoward commented Apr 7, 2020

Motivation

Update graphsync, data-transfer, and go-fil-markets.
Enable features from latest graphsync.

Background

Graphsync has some new enhancements:

  • Passing extensions in protocol requests to enable custom behavior
  • Hooks on requests and responses
  • The ability to lock down graphsync so it rejects all incoming requests unless a hook validates the request based on an extension (or other request data)
  • The ability to load from other block stores based on extensions

Proposed changes

  • Remove IPLD bridge from network initialization (IPLDBridge was a legacy concept that's been removed from graphsync)
  • Turn on default request rejection for Graphsync when constructing graphsync instance in network submodule
  • In graphsync fetcher, define a ChainsyncProtocolExtension to Graphsync (just a name -- no data for now), pass this with all outgoing requests
  • In syncer initialize add hook to graphsync instance to validate chainsync requests so they are accepted

Out Of Scope

  • loading from a different block store (need guidance on how you all want to do this)
  • more rigorous request validation of chainsync requests (needs discussion among implementations)
    Add Graphsync extension for chainsync to identify chainsync requests.

For Discussion

Is the syncer submodule the right place to register the hook? Maybe it should live inside the fetcher itself?

FYI

should be merged around the same time as filecoin-project/lotus#1520 which locks down graphsync in Lotus

@codecov-io
Copy link

codecov-io commented Apr 8, 2020

Codecov Report

Merging #3978 into master will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #3978   +/-   ##
======================================
- Coverage      46%     46%   -1%     
======================================
  Files         228     228           
  Lines       13121   13121           
======================================
- Hits         6129    6127    -2     
- Misses       6076    6077    +1     
- Partials      916     917    +1     

@cumtlzhy
Copy link

cumtlzhy commented Apr 11, 2020

Hi, how can I find my FIL token ? When I fed my address to the http://user.kittyhawk.wtf:9797/, it showing failed to send funds.

Update graphsync, data-transfer, and go-fil-markets. Turn on default request rejection for
graphsync. Add extension for chainsync to identify chainsync requests.
@acruikshank acruikshank merged commit 18df031 into master Apr 22, 2020
@zl03jsj zl03jsj deleted the feat/update-fil-markets branch July 14, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants