Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix struct name in comment #6428

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

wangjingcun
Copy link
Contributor

关联的Issues (Related Issues)

close

改动 (Proposed Changes)

修复评论中一些结构体的名称,借鉴自 #6380

已执行 make api-gen

cd ./venus-devtool/ && go run ./api-gen/ client
cd ./venus-devtool/ && go run ./api-gen/ doc
not found method:  EthSubscription
cd ./venus-devtool/ && go run ./api-gen/ mock

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 存在兼容性问题(接口, 配置,数据,灰度),如果存在需要进行文档说明 / This PR has compatibility issues (API, Configuration, Data, GrayRelease), if so, need to be documented.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23%. Comparing base (abd8427) to head (1896cfd).
Report is 2 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6428   +/-   ##
======================================
  Coverage      23%     23%           
======================================
  Files         742     742           
  Lines       93993   93993           
======================================
+ Hits        21947   21976   +29     
+ Misses      69175   69151   -24     
+ Partials     2871    2866    -5     

Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simlecode simlecode merged commit a088340 into filecoin-project:master Nov 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants