Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump libp2p from 0.51.1 to 0.51.2 #163

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 30, 2023

Bumps libp2p from 0.51.1 to 0.51.2.

Commits
  • be42f21 deps: bump regex from 1.7.1 to 1.7.3
  • 486ac8b chore: prepare libp2p v0.51.2
  • bd04591 deps: bump zeroize from 1.5.7 to 1.6.0
  • ea573b3 deps: bump bimap from 0.6.2 to 0.6.3
  • ce55601 deps: bump async-io from 1.12.0 to 1.13.0
  • 699a55b deps: bump actions/upload-pages-artifact from 1.0.7 to 1.0.8
  • 3d3ccfe fix(libp2p): export perf protocol
  • 4897b2e deps: bump async-trait from 0.1.66 to 0.1.67
  • 1a85e24 fix(quic): Downgrade driver shutdown log line from info to debug
  • 0ec701e ci(semver-checks): upgrade to cargo semver-checks v0.19.0
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Mar 30, 2023
@github-actions github-actions bot enabled auto-merge (squash) March 30, 2023 05:25
@dependabot dependabot bot force-pushed the dependabot/cargo/libp2p-0.51.2 branch from 7b91d4b to 7bfd992 Compare March 30, 2023 05:37
@bajtos
Copy link
Member

bajtos commented Mar 30, 2023

@mxinden upgrading libp2p from 0.51.1 to 0.51.2 is breaking our build, the compiler is reporting errors inside libp2p crates. Have you seen this problem before? Could you please advise how to fix it?

The failed job:
https://github.com/filecoin-station/zinnia/actions/runs/4560984094/jobs/8047388121

Compiler output:

   Compiling libp2p-allow-block-list v0.1.0
   Compiling libp2p-connection-limits v0.1.0
error[E0432]: unresolved import `libp2p_swarm::ToSwarm`
  --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/libp2p-allow-block-list-0.1.0/src/lib.rs:68:66
   |
68 |     PollParameters, THandler, THandlerInEvent, THandlerOutEvent, ToSwarm,
   |                                                                  ^^^^^^^
   |                                                                  |
   |                                                                  no `ToSwarm` in the root
   |                                                                  help: a similar name exists in the module: `Swarm`

error[E0432]: unresolved import `libp2p_swarm::ToSwarm`
  --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/libp2p-connection-limits-0.1.0/src/lib.rs:25:66
   |
25 |     PollParameters, THandler, THandlerInEvent, THandlerOutEvent, ToSwarm,
   |                                                                  ^^^^^^^
   |                                                                  |
   |                                                                  no `ToSwarm` in the root
   |                                                                  help: a similar name exists in the module: `Swarm`

For more information about this error, try `rustc --explain E0432`.
error: could not compile `libp2p-allow-block-list` due to previous error
warning: build failed, waiting for other jobs to finish...
error: could not compile `libp2p-connection-limits` due to previous error
Error: Process completed with exit code 101.

@bajtos bajtos self-assigned this Mar 30, 2023
@bajtos
Copy link
Member

bajtos commented Mar 30, 2023

I think the problem may be relevant to libp2p/rust-libp2p#3658.

We are using NetworkBehaviourAction in several places in ext/libp2p/peer/behaviour.rs, I would like to update those places to use the new ToSwarm type. I don't think it's required to fix our build though.

Bumps [libp2p](https://github.com/libp2p/rust-libp2p) from 0.51.1 to 0.51.2.
- [Release notes](https://github.com/libp2p/rust-libp2p/releases)
- [Changelog](https://github.com/libp2p/rust-libp2p/blob/master/CHANGELOG.md)
- [Commits](libp2p/rust-libp2p@libp2p-v0.51.1...libp2p-v0.51.2)

---
updated-dependencies:
- dependency-name: libp2p
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/cargo/libp2p-0.51.2 branch from 7bfd992 to cd2bee0 Compare March 30, 2023 12:51
@mxinden
Copy link

mxinden commented Mar 30, 2023

Thanks @bajtos for the ping. Further documented here: libp2p/rust-libp2p#3658 (review)

Can you run cargo update -p libp2p-swarm on this branch? That should upgrade your Cargo.lock to libp2p-swarm v0.42.1 and thus make ToSwarm available in all its dependents.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 13, 2023

Superseded by #173.

@dependabot dependabot bot closed this Apr 13, 2023
auto-merge was automatically disabled April 13, 2023 05:09

Pull request was closed

@dependabot dependabot bot deleted the dependabot/cargo/libp2p-0.51.2 branch April 13, 2023 05:09
@bajtos
Copy link
Member

bajtos commented Apr 13, 2023

cargo update -p libp2p-swarm

Nice trick! It fixed the compilation errors. Thank you for sharing it with me.

FWIW, I reviewed all libp2p crates in my dependency tree and updated the following one too:

❯ cargo update -p libp2p-identity
(...)
Updating libp2p-identity v0.1.0 -> v0.1.1
(...)

@bajtos
Copy link
Member

bajtos commented Apr 13, 2023

Superseded by #183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants