Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Quality: Renamed user control class names #14810

Merged
merged 5 commits into from
Feb 23, 2024
Merged

Code Quality: Renamed user control class names #14810

merged 5 commits into from
Feb 23, 2024

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Feb 22, 2024 •
edited
Loading

Summary

As the title.

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Related Feature: Improving Performance, optimizations, reliability and codebase  #4180
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    None

Screenshots

None

yaira2
yaira2 reviewed Feb 22, 2024
View reviewed changes
src/Files.App/Data/Contracts/IAddressToolbarViewModel.cs
{
public bool IsSearchBoxVisible { get; set; }

public bool IsEditModeEnabled { get; set; }

/// <summary>
/// Boolean to determine if the command palette is open
/// </summary>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the comment be kept?

Copy link
Member Author

@0x5bfa 0x5bfa Feb 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add back and add comments to all of them in the next time for sure.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this one back before I merge?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

yaira2
yaira2 previously approved these changes Feb 22, 2024
View reviewed changes
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Feb 22, 2024
@yaira2 yaira2 merged commit 3a3a718 into files-community:main Feb 23, 2024
6 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/Rename-UCInterfaces branch February 23, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 left review comments

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x5bfa @yaira2