Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Updated layout icons in the toolbar #14846

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Feature: Updated layout icons in the toolbar #14846

merged 2 commits into from
Feb 27, 2024

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Feb 26, 2024

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    For Feature: Slider to control thumbnail size #10492

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Confirm the toolbar icon displays for each layout

Screenshots (optional)
Add screenshots here.

Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I were you, I'd rename them like ColorIconLayoutSizesExtraLarge28x28 Using dot is not recommended in the MSDN.

@yaira2
Copy link
Member Author

yaira2 commented Feb 27, 2024

If I were you, I'd rename them like ColorIconLayoutSizesExtraLarge28x28 Using dot is not recommended in the MSDN.

I'll put the size last, but using dots makes the resource names more readable and also helps filter auto complete suggestions.

@yaira2 yaira2 merged commit 5557b23 into main Feb 27, 2024
5 checks passed
@yaira2 yaira2 deleted the ya/RenameIcons branch February 27, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants