-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Added tooltips to Layout Picker #14852
Feature: Added tooltips to Layout Picker #14852
Conversation
b5bfcdc
to
51eb33a
Compare
…om/0x5bfa/Files into 5bfa/Add-LayoutFlyoutSliderTooltip
…om/0x5bfa/Files into 5bfa/Add-LayoutFlyoutSliderTooltip
src/Files.App/Data/Factories/LocalizedEnumDescriptionFactory.cs
Outdated
Show resolved
Hide resolved
I've added Tiles as well. Should remove because there's one option and slider is not available? |
We might as well keep it |
@@ -3,19 +3,69 @@ | |||
|
|||
namespace Files.Core.Data.Enums | |||
{ | |||
/// <summary> | |||
/// Defines constant that specifies the icon/height size in Grid layout. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't specific to the icon height
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the comments accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4aca2df
to
0520b9b
Compare
@0x5bfa does the screen reader work correctly? |
Resolved / Related Issues
For Feature: Slider to control thumbnail size #10492
Summary
PR Checklist
Screenshots
None