Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added tooltips to Layout Picker #14852

Merged
merged 16 commits into from
Feb 27, 2024

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Feb 27, 2024

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    For Feature: Slider to control thumbnail size #10492

Summary

  • Added tooltip converter for Slider
  • Added xml comments

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Go to a folder
    2. Open Layout flyout
    3. See the tooltip is shown on hover

Screenshots

None

@yaira2 yaira2 force-pushed the 5bfa/Add-LayoutFlyoutSliderTooltip branch from b5bfcdc to 51eb33a Compare February 27, 2024 16:16
@0x5bfa
Copy link
Member Author

0x5bfa commented Feb 27, 2024

I've added Tiles as well. Should remove because there's one option and slider is not available?

@yaira2
Copy link
Member

yaira2 commented Feb 27, 2024

I've added Tiles as well. Should remove because there's one option and slider is not available?

We might as well keep it

@@ -3,19 +3,69 @@

namespace Files.Core.Data.Enums
{
/// <summary>
/// Defines constant that specifies the icon/height size in Grid layout.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't specific to the icon height

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the comments accordingly

yaira2
yaira2 previously approved these changes Feb 27, 2024
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 force-pushed the 5bfa/Add-LayoutFlyoutSliderTooltip branch from 4aca2df to 0520b9b Compare February 27, 2024 17:20
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Feb 27, 2024
@yaira2
Copy link
Member

yaira2 commented Feb 27, 2024

Did you check for accessibility? You can use Accessibility Insights for this.

@0x5bfa does the screen reader work correctly?

@yaira2 yaira2 changed the title Feature: Add a tooltip to layout size slider Feature: Added tooltips to Layout Picker Feb 27, 2024
@yaira2 yaira2 merged commit 83132c9 into files-community:main Feb 27, 2024
5 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/Add-LayoutFlyoutSliderTooltip branch April 14, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants