Fix: Save tab list on path change #14874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
force-pushed
the
ya/SaveTabsOnPathChange
branch
from
17498b7
to
c6415f7
Compare
yaira2
changed the title
yaira2
commented
Mar 1, 2024
| @@ -167,6 +167,9 @@ public async void TabItemContent_ContentChanged(object? sender, CustomTabViewIte | |||
| LoadPaneChanged(); | |||
| UpdateNavToolbarProperties(); | |||
| await NavigationHelpers.UpdateInstancePropertiesAsync(paneArgs); | |||
|
|
|||
| // Save the updated tab list | |||
| AppLifecycleHelper.SaveSessionTabs(); | |||
There was a problem hiding this comment.
For some time this code runs twice when a second pane is added
There was a problem hiding this comment.
This can be avoided by modifying PangeHolderPage.IsRightPaneVisible setter as follows:
set
{
if (value != _IsRightPaneVisible)
{
_IsRightPaneVisible = value;
if (!_IsRightPaneVisible)
{
ActivePane = PaneLeft;
Pane_ContentChanged(null, null);
}
NotifyPropertyChanged(nameof(IsRightPaneVisible));
NotifyPropertyChanged(nameof(IsMultiPaneActive));
}
}There was a problem hiding this comment.
Thanks! I pushed a commit with this change.
yaira2
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #14857