Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed localization issue in the Layout Picker #14883

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Mar 2, 2024

Summary

As the title.

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Layout flyout UI may be inconsistent due to localization #14880
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Change language to Italian
    2. Go to a folder in a Tiles layout
    3. Open the Layout Picker

Screenshots

Before After
image image

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 9610925 into files-community:main Mar 5, 2024
5 checks passed
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 5, 2024
@yaira2 yaira2 changed the title Fix: Fixed an issue where the Layout Picker UI is broken up in a certain localization Fix: Fixed localization issue in the Layout Picker Mar 5, 2024
@0x5bfa 0x5bfa deleted the 5bfa/Fix-LayoutPickerUI branch March 6, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Layout flyout UI may be inconsistent due to localization
2 participants