Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where window wasn't always brought to foreground #14917

Merged
merged 7 commits into from
Mar 10, 2024

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Mar 8, 2024

Summary

Working very well.

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Bring Files window to foreground when opening using shortcuts (Win + E) #14730
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Lanuch the app
    2. Bring another window (not Files) to foreground
    3. Activate with Win+E
    4. See the window will be brought to foreground

Screenshots

None

@yaira2
Copy link
Member

yaira2 commented Mar 8, 2024

Can we revert the changes in #13588?

@0x5bfa
Copy link
Member Author

0x5bfa commented Mar 8, 2024

This bring also when the app lanches for the first time.
So when user bring Chrome for example right after the lanuch, the app will be brought to the foreground. Should I limit to run this code to activation?

@yaira2
Copy link
Member

yaira2 commented Mar 10, 2024

So when user bring Chrome for example right after the lanuch, the app will be brought to the foreground. Should I limit to run this code to activation?

I think so, otherwise we can end up with the app being unexpectedly focused.

@0x5bfa
Copy link
Member Author

0x5bfa commented Mar 10, 2024

Done

yaira2
yaira2 previously approved these changes Mar 10, 2024
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title Feature: Bring to foreground Fix: Fixed issue where window wasn't always brought to foreground Mar 10, 2024
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Mar 10, 2024
@yaira2 yaira2 merged commit 6f1c26f into files-community:main Mar 10, 2024
6 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/Feature-BringToForeground branch March 11, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Bring Files window to foreground when opening using shortcuts (Win + E)
2 participants