Code Quality: Bump CsWin32 to latest available #15637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies some of our code, and eliminates the compiler warnings we saw from the `Files.App.Server` project due to that version being particularly old.
yaira2
changed the title
Thank you for testing, we have disabled to launch this server in order not to drop Admin launch (WinRT out-of-process apparently doesn't support RunAs). |
yaira2
approved these changes
Jun 20, 2024
yaira2
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies some of our code, and eliminates the compiler warnings we saw from the
Files.App.Serverproject due to that version being particularly old.Resolved / Related Issues
I'm actually volunteering this PR in response to an issue a Files community member filed against CsWin32, when it actually wasn't a bug there, but just old code in this repo.
WinMdRootinstead ofwinmdrootto supress CS8981 (type name is ASCII lowercase only) microsoft/CsWin32#1214Steps used to test these changes
I launched the program according to your README file, but the
Files.App.Server.dllapparently never even loaded, so I don't know how to test it.