Bringing custom shellcontextmenu #699

BuraChuhadar · 2020-04-25T18:29:23Z

No description provided.

yaira2 · 2020-04-27T15:21:28Z

@BuraChuhadar This is really exciting! Do you want me to mark this as a draft for now?

BuraChuhadar · 2020-04-28T01:51:00Z

Sounds good please mark it as draft. I am still working on it.

yaira2 · 2020-04-28T21:01:37Z

@BuraChuhadar Will this solve #719?

BuraChuhadar · 2020-05-01T01:11:02Z

@yaichenbaum I am currently working on phase 1. So I am not planning to bring File > New options yet. For those the full menu needs to re-written to close #719 . I am not sure how do you want to approach to that.

yaira2 · 2020-05-01T11:57:51Z

@yaichenbaum I am currently working on phase 1. So I am not planning to bring File > New options yet. For those the full menu needs to re-written to close #719 . I am not sure how do you want to approach to that.

Lets keep this limited to open with for now, however to plan ahead, is there a central place in the registry to pull a list of the item types you can create?

FelixZacher · 2020-05-03T14:21:52Z

I think i need some clarification on this.

As far as i understand this retrives the "open with" options for a filetype from the registry.
Does this include additional options, than using Windows "ApplicationPicker"? Or what are the benefits of using this approach instead of the "ApplicationPicker".

BuraChuhadar · 2020-05-03T16:29:11Z

You cannot bring File > New options from the registry. You would need to read it from the shell 32 DLL instead.

Files/UserControls/LayoutModes/PhotoAlbum.xaml

Files/Helpers/RegistryReader.cs

lukeblevins

Please address comment regarding WindowsPrincipal

lukeblevins · 2020-05-04T01:16:09Z

Sounds good please mark it as draft. I am still working on it.

Just saw this now. Let me know if this should be a draft.

Hopefully my feedback helps guide you, but I really like these changes so far,

BuraChuhadar · 2020-05-04T16:28:17Z

@yaichenbaum I finalized the code no need to draft it. Please take a look. I am seeing WindowsPrincipal class is being supported. If you still think that isn't the case or if there is a way to check if it is supported under UWP then I can take a look.

BuraChuhadar

I am seeing it as supported under UWP: https://stackoverflow.com/questions/36713824/how-to-get-group-infolike-guest-admin-etc-of-current-login-user-in-uwp-windo. Let me know if this is a concern.

lukeblevins · 2020-05-04T16:39:37Z

@BuraChuhadar The stack overflow link you sent stated that the API is intended for use inside a brokered component rather than the UWP component.

It doesn't seem supported here: https://docs.microsoft.com/en-us/dotnet/api/?view=dotnet-uwp-10.0&term=principal

BuraChuhadar · 2020-05-04T17:17:49Z

OK, I will take a look no problem to address WIndows Principal code.

lukeblevins · 2020-05-05T19:46:06Z

@BuraChuhadar Actually, I think it would be better if we removed that part altogether because modern Windows will essentially deprecate the concept of admin vs standard user. With the WinRT sandbox, users expect to be standard users, so we should always assume they are.

BuraChuhadar · 2020-05-18T02:08:08Z

@duke7553 it has been a while I couldn't focus on this. I added the changes you mentioned. Let's finish the phase one of this implementation. I will continue adding more features around this. Let me know if it looks good now. The administration security check has been removed from the code.

BuraChuhadar · 2020-06-13T04:54:38Z

@yaichenbaum this is ready for review. I took a step back and changed my decision from adding the icons due to restrictions of IconElement class under MenuFlyout class. I would wait to see WinUI 3.0 will deliver something better.

I am going to attach this discussion related to the FlyoutMenu icons: microsoft/microsoft-ui-xaml#1494

I updated the current:

1- Bringing CommandLineToArgvW to parse command registry from Win32API
2- Execution of the context menu was a problem for some applications. This has been fixed.
3- Improved MUIVerb support
4- Changed the ordering of the context menu items. Screenshot:

At this point this PR getting quite large. I would suggest let's merge this in as I will continue with other approaches to improve the overall quality with the context menus to pair up the functionality as much as I can with Windows' native explorer.

I am looking forward to hearing about the feedback.

lukeblevins

Very excellent work! Users will love this feature

tsvietOK · 2020-06-14T02:30:43Z

Exception when right clicking on the txt file.

BuraChuhadar · 2020-06-16T00:53:10Z

@tsvietOK I will add a null check around that in that case you won't be able to load the extra shell menu items. Thank you for sharing it.

BuraChuhadar · 2020-06-16T01:42:23Z

Never mind. I found the problem. I sent a fix for it and fixed the merge conflicts.

tsvietOK · 2020-06-16T16:08:11Z

@BuraChuhadar For some reason extended context menu displaying only after second right click on folder(or select it before right click). As i understand for the moment extended context menu is not working for files.

BuraChuhadar · 2020-06-16T16:18:19Z

@tsvietOK it should work for files as well. I didn't try directly right clicking. I will check once I have the chance.

BuraChuhadar · 2020-06-17T02:16:17Z

@tsvietOK sent another fix. I see that the opening of the context menu wasn't synchronizing with the UI correctly given that the registry call method was async. I sent a fix by simply waiting for the registry method read task to complete. Please let me know if you see anything else. Thanks.

yaira2 · 2020-06-17T04:45:19Z

@BuraChuhadar I tested the latest changes and for the first time, I was able to get it working 🎉. It feels kind of off without the icons, we are using custom icons in menus in a couple of places so if you are running into issues, let us know so we can work together to improve the UI.

tsvietOK · 2020-06-17T13:45:26Z

@BuraChuhadar I am probably doing something wrong, but when i right clicking on file, displaying only standard context menu. Can you share example screenshot on how it should look like.

BuraChuhadar · 2020-06-20T16:28:52Z

@yaichenbaum I won't be addressing the icons as I mentioned above. Native explorer has the same behavior. You are welcome to send another PR for the icons.

@tsvietOK please send me your reproducible steps. Otherwise, I would suggest merging these changes and address issues on later tickets. You are welcome to assign to me the upcoming issues.

Here is the video of working changes with directory and files. It is a youtube video click on it to see it under youtube:

tsvietOK · 2020-06-20T16:58:32Z

@BuraChuhadar maybe i don't have supported apps installed.
Can you check, should Notepad++ be displayed when right clicking on file?

BuraChuhadar · 2020-06-20T17:04:28Z

@tsvietOK this feature won't use shell context extensions. Which in this case Notepad++ is using shell context extensions. I am seeing there are articles around Microsoft not interested in supporting shell context extensions and yet there is still software out there using this. Even PowerToys under Microsoft project is using this.

I will try to bring shell context extension support with a different PR at the moment this PR supports only static shell context menus.

lukeblevins · 2020-06-20T17:05:43Z

@BuraChuhadar If this is ready to merge, I'd like to do so considering the vast amount of work you put into this. I'm really impressed!

BuraChuhadar · 2020-06-20T17:08:21Z

@duke7553 it is ready to merge. Thank you for the feedback.

Files/Views/LayoutModes/GridViewBrowser.xaml

yaira2 · 2020-06-21T05:46:11Z

@yaichenbaum I won't be addressing the icons as I mentioned above. Native explorer has the same behavior. You are welcome to send another PR for the icons.

@BuraChuhadar Great work on this PR! As far as I can tell, File Explorer does show the icons in the right click context menu.

BuraChuhadar · 2020-06-21T18:22:34Z

@xpoppyx you won't see all the available items in context menu from the explorer. This feature only implements the static context menus, not the dynamic ones. File a bug and assign it to me if you see there are potential issues with reproducible steps.

BuraChuhadar · 2020-06-21T18:24:34Z

@yaichenbaum not all the items under the native explorer has icons that's what I meant. MenuFlyout also doesn't support bitmap images so I am OK leaving like this. If you have a proposal or a helper method to assign bitmaps to a menu flyout component then I can bring the icons.

yaira2 · 2020-06-21T18:26:27Z

@yaichenbaum not all the items under the native explorer has icons that's what I meant. MenuFlyout also doesn't support bitmap images so I am OK leaving like this. If you have a proposal or a helper method to assign bitmaps to a menu flyout component then I can bring the icons.

That makes sense, in the future we should try to get that working. In the meantime your work helped implement one of the most requested features 🎉.

BuraChuhadar · 2020-06-21T18:32:05Z

@yaichenbaum implementing that would be challenging because the dynamic shell context menus are using COM implementation and depending on the STA or MTA thread apartment the rendering of the shell context menu changes. I am thinking to see if I can bring something by using PowerShell or cmd to query the shell context menu and render it like that. I will create another PR once I see it is possible.

tsvietOK · 2020-06-21T20:14:52Z

Files/Views/LayoutModes/GenericFileBrowser.xaml.cs

            {
-                AllView.SelectedItems.Add(item);
+                AllView.SelectedItem = selectedItem;


What purpose of this change? This broke file selection. File size on status bar is not more visible when changing view mode from GridViewBrowser to GenericFileBrowser and back.

BuraChuhadar mentioned this pull request Apr 25, 2020

Windows Explorer context menu #174

Closed

ghost added the needs - code review label Apr 25, 2020

yaira2 force-pushed the develop branch from ded1029 to 5322f37 Compare April 28, 2020 00:52

yaira2 mentioned this pull request Apr 30, 2020

Additional Features Missing. #726

Closed

yaira2 mentioned this pull request May 1, 2020

WIP: Develop #698

Closed

lukeblevins reviewed May 4, 2020

View reviewed changes

Files/UserControls/LayoutModes/PhotoAlbum.xaml Outdated Show resolved Hide resolved

lukeblevins reviewed May 4, 2020

View reviewed changes

Files/Helpers/RegistryReader.cs Outdated Show resolved Hide resolved

lukeblevins suggested changes May 4, 2020

View reviewed changes

BuraChuhadar force-pushed the develop branch from d784018 to c233327 Compare May 4, 2020 16:23

BuraChuhadar changed the title ~~WIP: Bringing custom shellcontextmenu~~ Bringing custom shellcontextmenu May 4, 2020

BuraChuhadar commented May 4, 2020

View reviewed changes

BuraChuhadar requested a review from lukeblevins May 4, 2020 16:30

yaira2 force-pushed the develop branch from 5fbff5c to 6eaa0a5 Compare May 4, 2020 17:31

lukeblevins removed their request for review May 17, 2020 01:30

BuraChuhadar force-pushed the develop branch 2 times, most recently from 69011fc to 35e95b5 Compare May 18, 2020 02:06

BuraChuhadar requested a review from lukeblevins May 18, 2020 02:06

BuraChuhadar force-pushed the develop branch from 24161ae to fc2977b Compare June 13, 2020 05:03

BuraChuhadar requested a review from lukeblevins June 13, 2020 15:27

lukeblevins approved these changes Jun 13, 2020

View reviewed changes

yaira2 requested a review from tsvietOK June 14, 2020 02:19

BuraChuhadar force-pushed the develop branch from ad3b4a2 to c961073 Compare June 16, 2020 01:33

174: First attempt on windows Explorer context menu

db5b383

BuraChuhadar force-pushed the develop branch from bae2682 to db5b383 Compare June 20, 2020 16:03

Fixing rebase issues

b18f548

lukeblevins merged commit a02295a into files-community:master Jun 20, 2020

gave92 reviewed Jun 20, 2020

View reviewed changes

Files/Views/LayoutModes/GridViewBrowser.xaml Show resolved Hide resolved

tsvietOK reviewed Jun 21, 2020

View reviewed changes

Bringing custom shellcontextmenu #699

Bringing custom shellcontextmenu #699

Conversation

BuraChuhadar commented Apr 25, 2020

yaira2 commented Apr 27, 2020 • edited Loading

BuraChuhadar commented Apr 28, 2020

yaira2 commented Apr 28, 2020

BuraChuhadar commented May 1, 2020 • edited Loading

yaira2 commented May 1, 2020

FelixZacher commented May 3, 2020

BuraChuhadar commented May 3, 2020

lukeblevins left a comment

Choose a reason for hiding this comment

lukeblevins commented May 4, 2020

BuraChuhadar commented May 4, 2020

BuraChuhadar left a comment

Choose a reason for hiding this comment

lukeblevins commented May 4, 2020

BuraChuhadar commented May 4, 2020

lukeblevins commented May 5, 2020

BuraChuhadar commented May 18, 2020 • edited Loading

BuraChuhadar commented Jun 13, 2020 • edited Loading

lukeblevins left a comment

Choose a reason for hiding this comment

tsvietOK commented Jun 14, 2020

BuraChuhadar commented Jun 16, 2020

BuraChuhadar commented Jun 16, 2020

tsvietOK commented Jun 16, 2020 • edited Loading

BuraChuhadar commented Jun 16, 2020

BuraChuhadar commented Jun 17, 2020

yaira2 commented Jun 17, 2020 • edited Loading

tsvietOK commented Jun 17, 2020

BuraChuhadar commented Jun 20, 2020 • edited Loading

tsvietOK commented Jun 20, 2020

BuraChuhadar commented Jun 20, 2020

lukeblevins commented Jun 20, 2020

BuraChuhadar commented Jun 20, 2020 • edited Loading

yaira2 commented Jun 21, 2020

BuraChuhadar commented Jun 21, 2020

BuraChuhadar commented Jun 21, 2020

yaira2 commented Jun 21, 2020 • edited Loading

BuraChuhadar commented Jun 21, 2020

tsvietOK Jun 21, 2020 • edited Loading

Choose a reason for hiding this comment

yaira2 commented Apr 27, 2020 •

edited

Loading

BuraChuhadar commented May 1, 2020 •

edited

Loading

BuraChuhadar commented May 18, 2020 •

edited

Loading

BuraChuhadar commented Jun 13, 2020 •

edited

Loading

tsvietOK commented Jun 16, 2020 •

edited

Loading

yaira2 commented Jun 17, 2020 •

edited

Loading

BuraChuhadar commented Jun 20, 2020 •

edited

Loading

BuraChuhadar commented Jun 20, 2020 •

edited

Loading

yaira2 commented Jun 21, 2020 •

edited

Loading

tsvietOK Jun 21, 2020 •

edited

Loading