Add promises support #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 8, 2018 13:11
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 2 +1
Lines 28 37 +9
Branches 9 12 +3
=====================================
+ Hits 28 37 +9
Continue to review full report at Codecov.
|
zimme
reviewed
May 9, 2018
| }) | ||
|
|
||
| if (isPromise(results)) { | ||
| results.then(resolved => { |
There was a problem hiding this comment.
It doesn't seem to handle the case when the promise is rejected?
There was a problem hiding this comment.
You're right ! But I took example on the final-form library where the rejected promises are never handled. I think the user of the library should be responsible to catch rejections and restore the chain :
{
field: 'foo',
updates: {
doubleFoo: (fooValue, allValues) =>
fetchExternalData(fooValue)
.then(data => {
throw 'An error occurred'
})
.catch(error => {
// doubleFoo will be set to `null`
return null
})
}
},
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles promises returned in
UpdatesByNameandUpdatesForAllfunctions, and updates form asynchronously (see #16).