Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwrap ReactDOM.findDOMNode #5

Merged
merged 1 commit into from
Jul 18, 2018
Merged

Conversation

erikras
Copy link
Member

@erikras erikras commented Jul 18, 2018

Closes #4.

@codecov
Copy link

codecov bot commented Jul 18, 2018

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #5   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          37     36    -1     
  Branches       16     16           
=====================================
- Hits           37     36    -1
Impacted Files Coverage Δ
src/Html5ValidationField.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cab743a...5dad861. Read the comment docs.

@erikras erikras merged commit 321bd66 into master Jul 18, 2018
@erikras erikras deleted the unwrap-react-dom-find-dom-node branch July 18, 2018 15:17
@erikras
Copy link
Member Author

erikras commented Jul 18, 2018

Published in v1.0.1.

dist/react-final-form-html5-validation.es.js went from 730K to 5.4K. 😱

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant