Java 9 support #105

iloveeclipse · 2016-06-05T10:27:36Z

Need updated ASM (6.0 snapshot works fine)
- We should temporarily host and build against a snapshot build, I can upload one
Need updated BCEL ?(current snapshot seem to work but probably lacks some new constructs). See Evaluate BCEL 6 update strategies #106 for BCEL update evaluation.
Need JRT FS support (I have a patch, missing: multi-module packages)
- Need update of runtime requirements and build to Java 8 (I have a patch)
Need Eclipse plugin support (I have a patch)
Need proper update of JavaVersion parser (see Update JavaVersion for JEP 223 compatibility #75 , must be adopted)
Requires minor version number increase (3.0 -> 3.1) at least.

amaembo · 2016-06-05T10:49:50Z

The following points may become issues:

Loading of JDK classes may fail as they are not in jars now, but in jimages.
String-concatenation based detectors will surely fail due to JEP 280 implementation

iloveeclipse · 2016-06-05T10:51:26Z

I have patch for reading classes from jimages, this is not a problem.

richardfearn · 2016-06-05T11:26:47Z

(Also posted to the findbugs-discuss list)

No objections to a private snapshot being used, but speaking as the maintainer of the Fedora FindBugs packages, I would very much appreciate it if you could:

Specify exactly which upstream commit the FindBugs snapshot is based on.
If a patch is needed on top of the upstream commit, include that patch in the FindBugs repository somewhere.

These two mean that Fedora can (continue to) rebuild BCEL for FindBugs from source.

The asm 6.0 snapshot was built from SVN 1818 version, from ASM_6_FEATURE branch.

The support is not complete, currently packages which exist in multiple modules aren't properly supported (java.awt is an example).

The right approach would be something like #75.

iloveeclipse · 2016-06-05T14:57:16Z

The first draft with Java 9 support is committed to java9 branch.
Currently known open issues (I'm working on it):

classes from multi-module packages not found (like java.awt)
[] JavaVersion parser must be properly implemented (see Update JavaVersion for JEP 223 compatibility #75 )

iloveeclipse · 2016-06-05T22:25:03Z

OK, just found out that in BCEL HEAD all classes moved to new package structure (because it makes fun and of course because _maven_ needs it, see https://issues.apache.org/jira/browse/BCEL-222).

If I ever needed any argument why maven is evil...

Anyway.
Updating to HEAD of BCEL 6.0 with Java 9 support will break all existing FB detectors.

I'm playing with the idea to create a git repository fork from they SVN repo (https://commons.apache.org/proper/commons-bcel/source-repository.html) and move all classes back in git. With this git repo it should be easy to track the changes in BCEL HEAD.

FB follows now the new JDK version scheme described in http://openjdk.java.net/jeps/223. Java versions before Java 9 will have 1 as major segment, and some meaningful number as major segment starting with Java 9. This should work for most cases.

iloveeclipse · 2016-06-09T08:45:30Z

FindBugs on Java 9 must work now, major work is done. Closing as fixed, new issues with Java 9 should be tracked by new tickets.

don-vip · 2016-06-09T09:03:50Z

Thanks! I see there are 3 branches for Java 9 development, from which one should we build a snapshot to test it in our application?

iloveeclipse · 2016-06-09T09:08:32Z

The sources are on the https://github.com/findbugsproject/findbugs/tree/java9_bcel6_old branch, see also the announcement https://mailman.cs.umd.edu/pipermail/findbugs-discuss/2016-June/004286.html.
You can also use pre-built binaries from https://github.com/findbugsproject/findbugs/releases/tag/3.1.0_preview1

don-vip · 2016-06-09T09:12:56Z

ok thanks! Congratulations for this release :)

don-vip · 2016-06-09T12:24:34Z

I have tested the new release on our project with JDK7, JDK8 and JDK9b121. It works perfectly with JDK8 and JDK9. However, the binaries have been compiled with JDK8, so we can't use it anymore with JDK7, is it intentional?

iloveeclipse · 2016-06-09T13:18:20Z

Yes. That's the prise for Java 9. We theoretically can run on Java 7 if we would use extra jrt-fs library recompiled on 7 (there was one on github) but we practically have no one who would have time to contribute it. I do not have time to support dead systems too.

iloveeclipse · 2016-06-09T13:52:18Z

See https://github.com/forax/jigsaw-jrtfs.

bmuschko · 2016-06-14T14:21:13Z

@iloveeclipse Do you have an ETA on when version 3.1.0 might be available on Maven Central as final version? I saw that there's a SNAPSHOT version available right now.

iloveeclipse · 2016-06-14T14:28:01Z

I hope to merge 3.1.0 preview code to master this month, because I'm waiting on user feedback & "official" ASM 6 and BCEL 6 preview builds, which should be available end of this week. I do not have concrete plans to publish "final" version, because Java 9 is not yet there and therefore many things may change.
I'm not using maven (and don't plan to do this in the future), so for maven support please ask on the project mailing list. I think there were few people previously doing this.

bmuschko · 2017-07-14T17:45:01Z

@iloveeclipse Is FindBugs still going to provide a Java 9-compatible version? I see that this issue has been closed.

iloveeclipse · 2017-07-18T12:11:28Z

The development is moved to https://github.com/spotbugs/spotbugs.
If you want help, please build & test against new JDK 9 build and report if there is a problem.

bmuschko · 2017-07-18T12:19:20Z

@iloveeclipse Thanks for the pointer. Is it correct to assume that FindBugs will never support Java 9 then? Instead users are supposed to use Spotbugs. Is that correct?

iloveeclipse · 2017-07-18T12:34:48Z

Never say never :-)
So far we did not hear anything from Bill Pugh since we asked for his help before forking the project, so you can assume that FindBugs project here is dead.

And yes, we are trying all we can do to minimize the pain for existing FindBugs users while transition to SpotBugs. I can say for myself that I'm running latest snapshot without any problems both as command line and Eclipse plugin, both on Java 8.

Java 9 changed so much in so many ways during the betas that I'm pretty sure it will not work out of the box with SpotBugs anymore. At some time I've given up to download and test them because it is really time consuming, but if you would take time for testing and report the issues, we will try to fix them.

bmuschko · 2017-07-18T12:40:52Z

@iloveeclipse Thanks, this information helps a lot.

iloveeclipse · 2017-07-18T14:08:59Z

Actually just tried the latest beta, SpotBugs works running on Java 9 with --add-modules=ALL-SYSTEM JVM argument just fine.

don-vip · 2017-07-18T17:31:56Z

Actually we're still using findbugs 3.1.0_preview2 with jdk9 on a weekly basis (for each new EA build) and it works fine! I'm pretty confident about Spotbugs' Java 9 support 👍
I'm waiting for RC4 before making the big switch :) Many thanks to all the Spotbugs team for all the hard work you're doing. It's really great to see you care about Findbugs users, while Bill seems more interested to tweet about American politics rather than maintain his software, or simply talk to the Java community...
By the way ASM 6.0 beta has just been released: https://mail.ow2.org/wws/arc/asm/2017-07/msg00002.html

iloveeclipse · 2017-07-18T17:37:18Z

Yep, we know it, see spotbugs/spotbugs#268

Compilation error fixes: - Avoid ambiguity error when appending to Properties in Scala code (scala/bug#10418) - Use position() and limit() to fix ambiguity issue ( scala/bug#10418 (comment)) - Disable findBugs if Java 9 is used ( findbugsproject/findbugs#105) Compilation warning fixes: - Avoid deprecated Class.newInstance in Utils.newInstance - Silence a few Java 9 deprecation warnings - var -> val and unused fixes Runtime error fixes: - Introduce Base64 class that works in Java 7 and Java 9 Also: - Set --release option if building with Java 9 Note that tests involving EasyMock (easymock/easymock#193) or PowerMock (powermock/powermock#783) will fail as neither supports Java 9 currently. Author: Ismael Juma <[email protected]> Reviewers: Jason Gustafson <[email protected]> Closes #3647 from ijuma/kafka-4501-support-java-9

For more information see findbugsproject/findbugs#105. It's recommended to use SpotBugs now.

The asm 6.0 snapshot was built from SVN 1818 version, from ASM_6_FEATURE branch.

…indbugsproject#105 The support is not complete, currently packages which exist in multiple modules aren't properly supported (java.awt is an example).

The right approach would be something like findbugsproject#75.

…oject#75 FB follows now the new JDK version scheme described in http://openjdk.java.net/jeps/223. Java versions before Java 9 will have 1 as major segment, and some meaningful number as major segment starting with Java 9. This should work for most cases.

iloveeclipse added enhancement java9 labels Jun 5, 2016

iloveeclipse mentioned this issue Jun 5, 2016

bcel updates #103

Closed

iloveeclipse self-assigned this Jun 5, 2016

iloveeclipse added this to the 3.1.0 milestone Jun 5, 2016

iloveeclipse added a commit that referenced this issue Jun 5, 2016

Switch to use ASM 6 with Java 9 support, see issue #105.

a9eb52b

The asm 6.0 snapshot was built from SVN 1818 version, from ASM_6_FEATURE branch.

iloveeclipse added a commit that referenced this issue Jun 5, 2016

Support for Java 9 JRT FS (classes packaged into jimage files), see #105

9e10194

The support is not complete, currently packages which exist in multiple modules aren't properly supported (java.awt is an example).

iloveeclipse added a commit that referenced this issue Jun 5, 2016

Quick hack to allow Java 9 version, see #105

4523b3d

The right approach would be something like #75.

iloveeclipse added a commit that referenced this issue Jun 5, 2016

Properly resolve multi-module packages, see #105

e4b9122

iloveeclipse added a commit that referenced this issue Jun 8, 2016

Fixed Java 9 support broken after 9d53929, see #105

7713145

iloveeclipse closed this as completed Jun 9, 2016

eriwen mentioned this issue Oct 19, 2016

Findbugs support for Java 9 gradle/gradle#720

Closed

ijuma mentioned this issue Aug 9, 2017

KAFKA-4501: Java 9 compilation and runtime fixes apache/kafka#3647

Closed

bmuschko pushed a commit to gradle/gradle that referenced this issue Feb 19, 2018

No FindBugs GA version supports Java 9

cd704e1

For more information see findbugsproject/findbugs#105. It's recommended to use SpotBugs now.

This was referenced Mar 3, 2018

Adopt spotbugs instead of findbugs ballerina-platform/ballerina-lang#4971

Closed

Spotbugs support (cherry picking commits, previously #4971) ballerina-platform/ballerina-lang#5009

Merged

sebasjm pushed a commit to sebasjm/findbugs that referenced this issue Mar 11, 2018

Switch to use ASM 6 with Java 9 support, see issue findbugsproject#105.

2e2c4ca

The asm 6.0 snapshot was built from SVN 1818 version, from ASM_6_FEATURE branch.

sebasjm pushed a commit to sebasjm/findbugs that referenced this issue Mar 11, 2018

Quick hack to allow Java 9 version, see findbugsproject#105

d0e182b

The right approach would be something like findbugsproject#75.

sebasjm pushed a commit to sebasjm/findbugs that referenced this issue Mar 11, 2018

Properly resolve multi-module packages, see findbugsproject#105

a9e94c2

sebasjm pushed a commit to sebasjm/findbugs that referenced this issue Mar 11, 2018

Fixed Java 9 support broken after 9d53929, see findbugsproject#105

c7face9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Java 9 support #105

Java 9 support #105

iloveeclipse commented Jun 5, 2016 •

edited

Loading

amaembo commented Jun 5, 2016 •

edited

Loading

iloveeclipse commented Jun 5, 2016

richardfearn commented Jun 5, 2016

iloveeclipse commented Jun 5, 2016 •

edited

Loading

iloveeclipse commented Jun 5, 2016

iloveeclipse commented Jun 9, 2016

don-vip commented Jun 9, 2016

iloveeclipse commented Jun 9, 2016 •

edited

Loading

don-vip commented Jun 9, 2016

don-vip commented Jun 9, 2016

iloveeclipse commented Jun 9, 2016

iloveeclipse commented Jun 9, 2016

bmuschko commented Jun 14, 2016

iloveeclipse commented Jun 14, 2016

bmuschko commented Jul 14, 2017

iloveeclipse commented Jul 18, 2017

bmuschko commented Jul 18, 2017

iloveeclipse commented Jul 18, 2017

bmuschko commented Jul 18, 2017

iloveeclipse commented Jul 18, 2017 •

edited

Loading

don-vip commented Jul 18, 2017

iloveeclipse commented Jul 18, 2017

Java 9 support #105

Java 9 support #105

Comments

iloveeclipse commented Jun 5, 2016 • edited Loading

amaembo commented Jun 5, 2016 • edited Loading

iloveeclipse commented Jun 5, 2016

richardfearn commented Jun 5, 2016

iloveeclipse commented Jun 5, 2016 • edited Loading

iloveeclipse commented Jun 5, 2016

iloveeclipse commented Jun 9, 2016

don-vip commented Jun 9, 2016

iloveeclipse commented Jun 9, 2016 • edited Loading

don-vip commented Jun 9, 2016

don-vip commented Jun 9, 2016

iloveeclipse commented Jun 9, 2016

iloveeclipse commented Jun 9, 2016

bmuschko commented Jun 14, 2016

iloveeclipse commented Jun 14, 2016

bmuschko commented Jul 14, 2017

iloveeclipse commented Jul 18, 2017

bmuschko commented Jul 18, 2017

iloveeclipse commented Jul 18, 2017

bmuschko commented Jul 18, 2017

iloveeclipse commented Jul 18, 2017 • edited Loading

don-vip commented Jul 18, 2017

iloveeclipse commented Jul 18, 2017

iloveeclipse commented Jun 5, 2016 •

edited

Loading

amaembo commented Jun 5, 2016 •

edited

Loading

iloveeclipse commented Jun 5, 2016 •

edited

Loading

iloveeclipse commented Jun 9, 2016 •

edited

Loading

iloveeclipse commented Jul 18, 2017 •

edited

Loading