Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RedundantInterfaces Serializable if check #49

Merged
merged 1 commit into from
Nov 15, 2015
Merged

Fix RedundantInterfaces Serializable if check #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion findbugs/src/java/edu/umd/cs/findbugs/detect/RedundantInterfaces.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public void visitClassContext(ClassContext classContext) {
SortedSet<String> redundantInfNames = new TreeSet<String>();

for (String interfaceName : interfaceNames) {
if (!"java/io/Serializable".equals(interfaceName)) {
if (!"java.io.Serializable".equals(interfaceName)) {
JavaClass inf = Repository.lookupClass(interfaceName.replace('/', '.'));
if (superObj.instanceOf(inf)) {
redundantInfNames.add(inf.getClassName());
Expand Down
33 changes: 33 additions & 0 deletions findbugsTestCases/src/java/ghIssues/Issue0049.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@

import java.io.Serializable;

import edu.umd.cs.findbugs.annotations.ExpectWarning;
import edu.umd.cs.findbugs.annotations.NoWarning;

public class Issue0049 {
public interface TestInterface {}

@NoWarning("RI_REDUNDANT_INTERFACES")
public static class SuperClass implements TestInterface {}

@ExpectWarning("RI_REDUNDANT_INTERFACES")
public static class SubClassWithDuplicate extends SuperClass implements TestInterface {}

@NoWarning("RI_REDUNDANT_INTERFACES")
public static class SubClassWithoutDuplicate extends SuperClass {}

@ExpectWarning("RI_REDUNDANT_INTERFACES")
public static class SubSubClassWithDuplicate extends SubClassWithoutDuplicate implements TestInterface {}

@NoWarning("RI_REDUNDANT_INTERFACES")
public static class SerializableSuperClass implements Serializable {}

@NoWarning("RI_REDUNDANT_INTERFACES")
public static class SerializableSubClassWithDuplicate extends SerializableSuperClass implements Serializable {}

@NoWarning("RI_REDUNDANT_INTERFACES")
public static class SerializableSubClassWithoutDuplicate extends SerializableSuperClass {}

@NoWarning("RI_REDUNDANT_INTERFACES")
public static class SerializableSubSubClassDuplicate extends SerializableSubClassWithoutDuplicate implements Serializable {}
}