Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forget_client (using forget_sta api) #49

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

yuphing-ong
Copy link

Nothing new, just cleaning up the lint errors from pull request #43 that stops it from being accepted.

@yuphing-ong yuphing-ong reopened this Oct 22, 2019
@finish06
Copy link
Owner

@yuphing-ong Can the block_client and unblock_client also use the new _macs_cmd function?

@yuphing-ong
Copy link
Author

yuphing-ong commented Oct 24, 2019

@yuphing-ong Can the block_client and unblock_client also use the new _macs_cmd function?

Unfortunately no. FYI _macs_cmd is just sending param 'macs':MACS, where MACS must be a list of macs (one or more). I'm not implementing any iteration, it's just what the Unifi API is expecting.

I'm using https://github.com/Art-of-WiFi/UniFi-API-client/blob/master/src/Client.php as a reference, so block_sta and unblock_sta only take cmd param 'mac' and a single mac, whereas forget_sta takes the param 'macs': '[...]'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants