Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple validation against samples #54

Merged
merged 8 commits into from
Mar 13, 2024

Conversation

willosborne
Copy link
Member

Addresses issue #35 - simple rule on all samples.
Currently doesn't do pattern files as the rules don't understand the json metaschema syntax yet.

@willosborne willosborne requested a review from a team as a code owner March 12, 2024 15:55
@willosborne
Copy link
Member Author

Note - branch is passing even though validation fails because it doesn't seem to have permission.
stoplightio/spectral-action#624 Seems others have had this problem.

Concern that this may just not work for PRs from forks: italia/developers-italia-api#67

@willosborne willosborne marked this pull request as draft March 12, 2024 17:43
willosborne and others added 3 commits March 12, 2024 17:45
I think this is the syntax for what you want to achieve
@rocketstack-matt rocketstack-matt marked this pull request as ready for review March 13, 2024 10:17
@rocketstack-matt rocketstack-matt merged commit ba82566 into finos:main Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants