Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass through template copyright and license to generated service runner classes, as agreed with OSS #387

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rafaelbey
Copy link
Contributor

No description provided.

@@ -1,18 +1,17 @@
<#--
Copyright 2022 Goldman Sachs
// Copyright 2022 Goldman Sachs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two questions on this, and I genuinely don't know the answer to either one.

First, do we need to keep the previous license/copyright statement? Or does the license/copyright that's part of the template constitute a license/copyright on the template itself?

Second, is 2022 the right year for the copyright? Presumably, people will be generating code from this template in 2023 and later. Should the year for generated copyrights be the year in which the code is generated (meaning the year needs to be templatized)? Or should be the year be the same as the year of the copyright of the template itself (meaning 2022 is correct)?

@@ -1,18 +1,17 @@
<#--
Copyright 2022 Goldman Sachs
// Copyright 2022 Goldman Sachs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two questions on this, and I genuinely don't know the answer to either one.

First, do we need to keep the previous license/copyright statement? Or does the license/copyright that's part of the template constitute a license/copyright on the template itself?

Second, is 2022 the right year for the copyright? Presumably, people will be generating code from this template in 2023 and later. Should the year for generated copyrights be the year in which the code is generated (meaning the year needs to be templatized)? Or should be the year be the same as the year of the copyright of the template itself (meaning 2022 is correct)?

@rafaelbey rafaelbey marked this pull request as draft March 21, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants