Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Improve test coverage of ReviewsResource #465

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

edmondop
Copy link
Contributor

@edmondop edmondop commented Jul 4, 2022

This pr addresses #128 trying to add test coverage for review resource.

The current proposal is to introduce a request builder that provides a fluent API to the backend, or even a typed client and reduce the excessive boilerplate and copy-paste in the tests of the Rest port.

TODOS:

  • fully implement the helper
  • add tests for the ReviewResource

@finos-cla-bot
Copy link

finos-cla-bot bot commented Jul 4, 2022

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement; having reviewed our contributor list, we require a CLA for the following people : (@edmondo1984).

In order to sign a CLA with FINOS, just submit a Pull Request with a simple change to this file (adding an empty line, or some random text at the bottom); this will trigger the EasyCLA bot, which will post a comment to the Pull Request stating whether all PR contributors are covered by FINOS CLA; if not covered, the bot will post instructions on how to sign the CLA.

Thanks once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request. Feel free to email [email protected] for any questions.

cc @TheJuanAndOnly99 @mcleo-d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant