add TEMPORARY__enableExportToCube to queryBuilderConfig (#3571)

finos · Oct 7, 2024 · 46c4b28 · 46c4b28
1 parent 7800906
commit 46c4b28
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 23 deletions.
diff --git a/.changeset/angry-cherries-stare.md b/.changeset/angry-cherries-stare.md
@@ -0,0 +1,3 @@
+---
+'@finos/legend-query-builder': patch
+---
diff --git a/packages/legend-query-builder/src/components/result/QueryBuilderResultPanel.tsx b/packages/legend-query-builder/src/components/result/QueryBuilderResultPanel.tsx
@@ -46,6 +46,7 @@ import {
   CubesLoadingIndicator,
   InfoCircleIcon,
   ShareBoxIcon,
+  CubeIcon,
 } from '@finos/legend-art';
 import { observer } from 'mobx-react-lite';
 import { flowResult } from 'mobx';
@@ -56,6 +57,7 @@ import {
   TDSExecutionResult,
   RawExecutionResult,
   ExecutionError,
+  RuntimePointer,
 } from '@finos/legend-graph';
 import {
   ActionAlertActionType,
@@ -837,27 +839,28 @@ export const QueryBuilderResultPanel = observer(
                     </MenuContentItemIcon>
                     <MenuContentItemLabel>Others...</MenuContentItemLabel>
                   </MenuContentItem>
-                  {/* DISABLE FOR NOW */}
-                  {/* <MenuContentItem
-                    onClick={(): void =>
-                      queryBuilderState.setIsCubeEnabled(true)
-                    }
-                    disabled={
-                      !queryBuilderState.fetchStructureState.implementation
-                        .canBeExportedToCube ||
-                      !(
-                        queryBuilderState.executionContextState
-                          .runtimeValue instanceof RuntimePointer
-                      )
-                    }
-                  >
-                    <MenuContentItemIcon>
-                      <CubeIcon />
-                    </MenuContentItemIcon>
-                    <MenuContentItemLabel>
-                      Data Cube (BETA)
-                    </MenuContentItemLabel>
-                  </MenuContentItem> */}
+                  {queryBuilderState.config?.TEMPORARY__enableExportToCube && (
+                    <MenuContentItem
+                      onClick={(): void =>
+                        queryBuilderState.setIsCubeEnabled(true)
+                      }
+                      disabled={
+                        !queryBuilderState.fetchStructureState.implementation
+                          .canBeExportedToCube ||
+                        !(
+                          queryBuilderState.executionContextState
+                            .runtimeValue instanceof RuntimePointer
+                        )
+                      }
+                    >
+                      <MenuContentItemIcon>
+                        <CubeIcon />
+                      </MenuContentItemIcon>
+                      <MenuContentItemLabel>
+                        Data Cube (BETA)
+                      </MenuContentItemLabel>
+                    </MenuContentItem>
+                  )}
                   {extraExportMenuContentItems}
                 </MenuContent>
               }

diff --git a/packages/legend-query-builder/src/graph-manager/QueryBuilderConfig.ts b/packages/legend-query-builder/src/graph-manager/QueryBuilderConfig.ts
@@ -19,7 +19,12 @@ import { createModelSchema, optional, primitive } from 'serializr';
 
 export class QueryBuilderConfig {
   /**
-   * This flag is to disable query builder chat feature
+   * This flag is to enable export to cube
+   */
+  TEMPORARY__enableExportToCube = false;
+
+  /**
+   * This flag is to disable query builder chat features
    */
   TEMPORARY__disableQueryBuilderChat = false;
 
@@ -41,6 +46,7 @@ export class QueryBuilderConfig {
   static readonly serialization = new SerializationFactory(
     createModelSchema(QueryBuilderConfig, {
       TEMPORARY__disableQueryBuilderChat: optional(primitive()),
+      TEMPORARY__enableExportToCube: optional(primitive()),
       TEMPORARY__enableGridEnterpriseMode: optional(primitive()),
       legendAIServiceURL: optional(primitive()),
       zipkinTraceBaseURL: optional(primitive()),

diff --git a/packages/legend-query-builder/src/stores/QueryBuilderState.ts b/packages/legend-query-builder/src/stores/QueryBuilderState.ts
@@ -265,7 +265,6 @@ export abstract class QueryBuilderState implements CommandRegistrar {
 
     this.workflowState = workflowState;
     this.sourceInfo = sourceInfo;
-    //extra check for only QA currently.
     this.isQueryChatOpened =
       (!this.config?.TEMPORARY__disableQueryBuilderChat &&
         this.applicationStore.settingService.getBooleanValue(