Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle creation of tests for service stores #2414

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

MauricioUyaguari
Copy link
Member

@MauricioUyaguari MauricioUyaguari commented Jul 9, 2023

Summary

  • add extensions for creating embedded data with connection, set imp
  • implement above extensions for service store

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@MauricioUyaguari MauricioUyaguari requested a review from a team as a code owner July 9, 2023 23:09
@changeset-bot
Copy link

changeset-bot bot commented Jul 9, 2023

🦋 Changeset detected

Latest commit: 20c7053

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@finos/legend-extension-store-service-store Patch
@finos/legend-application-studio Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-manual-tests Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-mastery Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Merging #2414 (20c7053) into master (e4cfe7a) will decrease coverage by 0.01%.
The diff coverage is 12.50%.

@@            Coverage Diff             @@
##           master    #2414      +/-   ##
==========================================
- Coverage   40.95%   40.94%   -0.01%     
==========================================
  Files        1539     1539              
  Lines       73020    73043      +23     
  Branches    17254    17263       +9     
==========================================
+ Hits        29908    29911       +3     
- Misses      42987    43007      +20     
  Partials      125      125              
Impacted Files Coverage Δ
...tor-group/mapping-editor/MappingTestableEditor.tsx 25.91% <ø> (ø)
...tor-state/mapping/testable/MappingTestableState.ts 14.05% <ø> (ø)
...on-studio/src/stores/editor/utils/TestableUtils.ts 36.41% <11.76%> (-2.63%) ⬇️
...tor-state/mapping/testable/MappingTestingHelper.ts 49.47% <14.28%> (-2.80%) ⬇️

@akphi akphi merged commit f764ced into finos:master Jul 10, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants