Add Generate Models button to enable autogeneration of classes, associations, and mapping feature for relational databases #2455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b074bbb The changes in this PR will be included in the next version bump. This PR includes changesets to release 23 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #2455 +/- ##
==========================================
- Coverage 41.75% 41.66% -0.10%
==========================================
Files 1584 1585 +1
Lines 74817 75049 +232
Branches 17592 17671 +79
==========================================
+ Hits 31242 31266 +24
- Misses 43449 43658 +209
+ Partials 126 125 -1
|
…iations, and mapping feature for relational databases
jake-kim1
force-pushed
the
feature_autogen_front
branch
from
530fca2
to
77eabdf
Compare
MauricioUyaguari
requested changes
Jul 31, 2023
There was a problem hiding this comment.
can we add a video of the workflow here. Not sure I agree with the approach of just generating the models directly without first showing the users the models that will be added to the project. this is the approach we do for generate database and we should follow a similar approach.
.changeset/sixty-carpets-cheat.md
Outdated
| '@finos/legend-graph': patch | ||
| --- | ||
|
|
||
| Add Generate Models button to enable autogeneration of classes, associations, and mapping feature for relational databases |
There was a problem hiding this comment.
lets separate this to two changeste files
The above message can stay for @finos/legend-application-studio but should be a minor change.
For the @finos/legend-graph we can keep empty.
packages/legend-application-studio/src/components/editor/side-bar/Explorer.tsx
Outdated
Show resolved
Hide resolved
MauricioUyaguari
requested changes
Jul 31, 2023
packages/legend-application-studio/src/components/editor/side-bar/Explorer.tsx
Outdated
Show resolved
Hide resolved
packages/legend-application-studio/src/components/editor/side-bar/Explorer.tsx
Outdated
Show resolved
Hide resolved
packages/legend-application-studio/src/components/editor/side-bar/Explorer.tsx
Outdated
Show resolved
Hide resolved
MauricioUyaguari
approved these changes
Jul 31, 2023
5 tasks
autogen_demo.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a "Generate Models" button when right-clicking on a relational database, which calls the API for autogeneration of classes, and associations, and mapping. Additionally, when the user does not define any joins in the relational database, a pop-up appears with an option to either proceed or abort.
Note:
This PR depends on finos/legend-engine#2070 which has been merged in Legend Engine