Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Data Generation I - support generating schemas/tables from query without authentication #2487

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

YannanGao-gs
Copy link
Contributor

@YannanGao-gs YannanGao-gs commented Aug 8, 2023

Summary

Test Data Generation I - support a new API to generate skeleton schema/table from query

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)
Screen_Recording_2023-08-02_at_10.42.18_PM.mov

@YannanGao-gs YannanGao-gs requested a review from a team as a code owner August 8, 2023 17:14
@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2023

🦋 Changeset detected

Latest commit: 5be3878

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@finos/legend-application-studio Patch
@finos/legend-graph Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-mastery Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-query Patch
@finos/legend-lego Patch
@finos/legend-manual-tests Patch
@finos/legend-query-builder Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-query-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@YannanGao-gs YannanGao-gs self-assigned this Aug 8, 2023
@YannanGao-gs YannanGao-gs added the Status: Waiting for Backend Change The PR should not be merged if the changes in the backend has not been live yet label Aug 8, 2023
@YannanGao-gs YannanGao-gs marked this pull request as draft August 8, 2023 17:19
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #2487 (5be3878) into master (e788d13) will decrease coverage by 0.02%.
Report is 4 commits behind head on master.
The diff coverage is 15.21%.

@@            Coverage Diff             @@
##           master    #2487      +/-   ##
==========================================
- Coverage   41.63%   41.62%   -0.02%     
==========================================
  Files        1590     1593       +3     
  Lines       75354    75416      +62     
  Branches    17745    17756      +11     
==========================================
+ Hits        31377    31389      +12     
- Misses      43852    43902      +50     
  Partials      125      125              
Files Changed Coverage Δ
...raph/src/graph-manager/AbstractPureGraphManager.ts 30.55% <ø> (ø)
...ph-manager/protocol/pure/v1/V1_PureGraphManager.ts 45.41% <0.00%> (-0.33%) ⬇️
...graph-manager/protocol/pure/v1/engine/V1_Engine.ts 18.68% <0.00%> (-0.14%) ⬇️
...ackageableElements/service/TestGenerationResult.ts 0.00% <0.00%> (ø)
...tor-state/service/testable/ServiceTestDataState.ts 35.75% <11.76%> (-2.52%) ⬇️
.../service-editor/testable/ServiceTestDataEditor.tsx 32.05% <25.00%> (-0.19%) ⬇️
...e/v1/engine/service/V1_TestDataGenerationResult.ts 25.00% <25.00%> (ø)
...r/protocol/pure/v1/engine/V1_EngineServerClient.ts 53.37% <33.33%> (-0.42%) ⬇️
...re/v1/engine/service/V1_TestDataGenerationInput.ts 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

@YannanGao-gs YannanGao-gs marked this pull request as ready for review August 9, 2023 13:56
Copy link
Member

@MauricioUyaguari MauricioUyaguari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes to be fixed for merging.
Main things are:

  1. lets remove skeleton naming from code as seems to crude
  2. fix erroring messaging in the generateTestData

Other thing, which we can fix after, what is the reason we need runtime to be a runtimePointer?

@YannanGao-gs
Copy link
Contributor Author

what is the reason we need runtime to be a runtimePointer

Engine needs runtime path

@YannanGao-gs YannanGao-gs reopened this Aug 10, 2023
@YannanGao-gs YannanGao-gs changed the title Test Data Generation I - support a new API to generate skeleton schema/table from query Test Data Generation I - support generating schemas/tables from query without authentication Aug 10, 2023
@MauricioUyaguari MauricioUyaguari merged commit 246fa96 into finos:master Aug 10, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Waiting for Backend Change The PR should not be merged if the changes in the backend has not been live yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants