Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional graphFetchPath attribute in PersistenceTestSpec #2488

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

ankitamritraj
Copy link
Contributor

@ankitamritraj ankitamritraj commented Aug 8, 2023

Summary

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@ankitamritraj ankitamritraj requested a review from a team as a code owner August 8, 2023 17:49
@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2023

🦋 Changeset detected

Latest commit: 4f0f571

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@finos/legend-extension-dsl-persistence Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-manual-tests Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #2488 (4f0f571) into master (9b53ade) will decrease coverage by 0.04%.
Report is 24 commits behind head on master.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #2488      +/-   ##
==========================================
- Coverage   41.67%   41.64%   -0.04%     
==========================================
  Files        1584     1590       +6     
  Lines       75000    75362     +362     
  Branches    17663    17751      +88     
==========================================
+ Hits        31256    31381     +125     
- Misses      43619    43854     +235     
- Partials      125      127       +2     
Files Changed Coverage Δ
.../changeDetection/DSL_Persistence_ObserverHelper.ts 17.24% <ø> (ø)
.../pureProtocol/V1_DSL_Persistence_ProtocolHelper.ts 73.74% <ø> (ø)
.../persistence/V1_DSL_Persistence_PersistenceTest.ts 66.66% <33.33%> (-33.34%) ⬇️
...nts/persistence/DSL_Persistence_PersistenceTest.ts 66.66% <33.33%> (-33.34%) ⬇️
...ure/DSL_Persistence_PureProtocolProcessorPlugin.ts 74.65% <100.00%> (+0.35%) ⬆️

... and 67 files with indirect coverage changes

@akphi akphi merged commit ade5e57 into finos:master Aug 10, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants