Add QueryBuilder to VS Code extension #3499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 679b8a8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3499 +/- ##
=========================================
Coverage 45.78% 45.79%
=========================================
Files 2129 2129
Lines 367035 367103 +68
Branches 15314 11301 -4013
=========================================
+ Hits 168059 168120 +61
- Misses 198235 198317 +82
+ Partials 741 666 -75
|
travisstebbins
force-pushed
the
vs-code-service-query-builder
branch
from
84bdacc
to
5da1b79
Compare
travisstebbins
changed the title
travisstebbins
commented
Sep 6, 2024
| @@ -4015,7 +4015,7 @@ export class V1_PureGraphManager extends AbstractPureGraphManager { | |||
| return graphData; | |||
| } | |||
|
|
|||
| private elementToProtocol = <T extends V1_PackageableElement>( | |||
| elementToProtocol = <T extends V1_PackageableElement>( | |||
There was a problem hiding this comment.
I had to make this function public because the VS code extension uses the v1 protocol for interacting with the language server, and to save the service to a file, we need to convert the Service object to a V1_Service object and send it to the language server. Since this function already existed in V1_PureGraphManager, it seemed simpler to make it public rather than duplicate the logic somewhere else.
travisstebbins
force-pushed
the
vs-code-service-query-builder
branch
from
0252b6e
to
679b8a8
Compare
MauricioUyaguari
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How did you test this change?
No testing as this PR largely just forwards exports.