Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MR | Subtypes support in data quality class validation #3594

Merged
merged 0 commits into from
Oct 14, 2024

Conversation

viju4076
Copy link
Contributor

Summary

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@viju4076 viju4076 requested a review from a team as a code owner October 14, 2024 08:08
Copy link

changeset-bot bot commented Oct 14, 2024

⚠️ No Changeset found

Latest commit: 7800906

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 61 lines in your changes missing coverage. Please review.

Project coverage is 45.11%. Comparing base (7800906) to head (4feaaf6).
Report is 22 commits behind head on master.

Files with missing lines Patch % Lines
.../components/utils/DataQualityGraphFetchTreeUtil.ts 0.00% 29 Missing ⚠️
...uality/src/components/DataQualityExplorerPanel.tsx 0.00% 22 Missing ⚠️
...src/components/DataQualityConstraintsSelection.tsx 0.00% 9 Missing ⚠️
...V1_DSL_DataQuality_ValueSpecificationSerializer.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3594      +/-   ##
==========================================
- Coverage   45.51%   45.11%   -0.40%     
==========================================
  Files        2158     2163       +5     
  Lines      372977   373959     +982     
  Branches    10302    10649     +347     
==========================================
- Hits       169761   168729    -1032     
- Misses     202778   204541    +1763     
- Partials      438      689     +251     
Files with missing lines Coverage Δ
...V1_DSL_DataQuality_ValueSpecificationSerializer.ts 0.00% <0.00%> (ø)
...src/components/DataQualityConstraintsSelection.tsx 0.00% <0.00%> (ø)
...uality/src/components/DataQualityExplorerPanel.tsx 0.00% <0.00%> (ø)
.../components/utils/DataQualityGraphFetchTreeUtil.ts 0.00% <0.00%> (ø)

... and 468 files with indirect coverage changes

@gs-opensource-bot gs-opensource-bot force-pushed the review-vivija-subtypes-dq branch 3 times, most recently from 4feaaf6 to 7800906 Compare October 14, 2024 20:53
@MauricioUyaguari MauricioUyaguari merged commit 7800906 into finos:master Oct 14, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants