Fix plugin switch
#2828
Merged
Fix plugin switch
#2828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Stein <[email protected]>
texodus
force-pushed
the
fix-switch-plugin
branch
from
f74cf3f
to
1945b40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression in the
PerspectiveWidgetPython extension. In3.0.0, selection modes were added to Perspective's datagrid component; however, we neglected to test this feature when the settings are updated for a detached (hidden) viewer. This is not a common feature typically, but is coincidentally a state of the defaultPerspectiveWidgetloading workflow due to the lack of a working end-to-end async model forperspectiveandperspective-viewerremote calls. As a result, switching to the Datagrid plugin in Jupyter will throw a runtime exception.This PR fixes patches this behavior and adds a test for JupyterLab. However, it does not resolve the underlying inconsistency which is async ordering issues imposed by the current
PerspectiveWidgetarchitecture. We will need to figure out why the current widget detaches during this call, as it is likely a sign of a deeper performance-sapping bug.Fixes #2827