fix(fcm): A workaround for the concurrency issues in googleapiclient #558
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a possible solution to the problem outlined in #507. I wasn't quite able to repro the exception in the bug report, but the threading issues in
googleapiclient
are well known, and I can easily reproduce some concurrency issues by callingsend_all()
from just 3-4 parallel threads. The proposed solution is to instantiate a new transport instance for each invocation ofsend_all()
(as opposed to using a shared transport across calls), and tests indeed confirm that it resolves the issues I managed to reproduce.