Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vertex AI] Add sysInstructs, tools, genConfig to countTokens #13813

Merged
merged 2 commits into from
Oct 4, 2024
Merged

[Vertex AI] Add sysInstructs, tools, genConfig to countTokens #13813

merged 2 commits into from
Oct 4, 2024

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Oct 4, 2024 •
edited
Loading

Added systemInstruction, tools and generationConfig to the CountTokensRequest body. These fields are now included in the totalTokens and totalBillableCharacters counts.

@andrewheard andrewheard added this to the 11.4.0 - M155 milestone Oct 4, 2024
@andrewheard andrewheard marked this pull request as ready for review October 4, 2024 20:56
@andrewheard andrewheard merged commit 688af80 into main Oct 4, 2024
38 checks passed
@andrewheard andrewheard deleted the ah/vertex-count-tokens branch October 4, 2024 21:20
@github-actions github-actions bot mentioned this pull request Oct 22, 2024
Merged
@firebase firebase locked and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: vertexai
Projects
None yet
Milestone
11.4.0 - M155
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewheard @paulb777 @google-oss-bot