Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vertex AI] Refactor FinishReason as a struct and add new values #13860

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Oct 9, 2024

Replaced the FinishReason enum with a struct to prevent breaking changes when new values are added (since switch statements must be exhaustively checked in Swift). Added the new values blocklist, prohibitedContent, spii and malformedFunctionCall.

@andrewheard andrewheard added this to the 11.4.0 - M155 milestone Oct 9, 2024
@andrewheard andrewheard marked this pull request as ready for review October 9, 2024 19:02
@andrewheard andrewheard merged commit 20c9413 into main Oct 9, 2024
38 checks passed
@andrewheard andrewheard deleted the ah/vertex-finishreason branch October 9, 2024 20:30
MojtabaHs pushed a commit to MojtabaHs/firebase-ios-sdk that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants