Not sending messages to closed websocket connections #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe this should be a safe change since the timer function nop is only ever run after the websocket is initialized. This works around potential issues in the websocket layer after we close the connection and hopefully addresses https://b.corp.google.com/issues/62363018x
schmidt-sebastian
force-pushed
the
mrschmidt-databasecrash
branch
from
4ce2baf
to
7171629
Compare
|
@paulb777 Paul, it looks like the Travis build passed but took longer than the 10 minute timeout. Can you let me know if we are ok to merge? |
|
OK to merge. Thanks! |
paulb777
approved these changes
Jun 22, 2017
XiangtianDai
pushed a commit
that referenced
this pull request
Jul 28, 2017
remove language code english fallback
minafarid
pushed a commit
to minafarid/firebase-ios-sdk
that referenced
this pull request
Jun 6, 2018
I believe this should be a safe change since the timer function nop is only ever run after the websocket is initialized. This works around potential issues in the websocket layer after we close the connection and hopefully addresses https://b.corp.google.com/issues/62363018x
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a safe change since the timer function 'nop' is only ever run after the WebSocket is initialized.
This works around potential issues in the WebSocket layer after we close the connection and should address Google-internal issue: https://b.corp.google.com/issues/62363018