getBytes #4973

schmidt-sebastian · 2021-06-03T21:17:22Z

Adds getBytes, getBlob and getStream APIs which allows file downloads without a public download URL. These bytes can then be used directly as an image source.

This PR contains a bunch of refactors to make this possible:

There are now three types of Connections. Connection<string>, Connection<ArrayBuffer> and Connection<ReadableStream>.
Each connection type has a distinct implementation for Node and Browsers.
There is no more ConnectionPool. ConnectionPool mostly seemed to be used to facilitate dependency injection for unit tests and never re-used connections. Instead, I added manual global overrides that provide the same functionality. This is not as elegant as before, but it allows the unused connections to be tree-shaken.

Fixes #76

changeset-bot · 2021-06-03T21:17:24Z

⚠️ No Changeset found

Latest commit: 1099618

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot · 2021-06-03T21:44:15Z

Binary Size Report

Affected SDKs

`@firebase/app`

Type	Base (`0a91a90`)	Head (`2892d3b`)	Diff
browser	11.0 kB	11.0 kB	+1 B (+0.0%)
esm2017	9.80 kB	9.80 kB	+1 B (+0.0%)
lite	8.93 kB	8.93 kB	+1 B (+0.0%)
lite-esm2017	7.93 kB	7.93 kB	+1 B (+0.0%)
main	10.1 kB	10.1 kB	+1 B (+0.0%)
module	11.0 kB	11.0 kB	+1 B (+0.0%)
react-native	9.86 kB	9.86 kB	+1 B (+0.0%)

`@firebase/firestore`

Type	Base (`0a91a90`)	Head (`2892d3b`)	Diff
browser	285 kB	285 kB	+168 B (+0.1%)
esm2017	227 kB	227 kB	+4 B (+0.0%)
module	285 kB	285 kB	+168 B (+0.1%)
react-native	227 kB	227 kB	+4 B (+0.0%)

`@firebase/firestore-compat`

Type	Base (`0a91a90`)	Head (`2892d3b`)	Diff
browser	29.0 kB	29.0 kB	+1 B (+0.0%)
main	38.2 kB	38.2 kB	+1 B (+0.0%)
module	29.0 kB	29.0 kB	+1 B (+0.0%)
react-native	28.7 kB	28.7 kB	+1 B (+0.0%)

`@firebase/firestore/bundle`

Type	Base (`0a91a90`)	Head (`2892d3b`)	Diff
browser	291 kB	291 kB	+5 B (+0.0%)
esm2017	177 kB	177 kB	+5 B (+0.0%)
main	528 kB	528 kB	+1 B (+0.0%)
module	291 kB	291 kB	+5 B (+0.0%)
react-native	177 kB	177 kB	+5 B (+0.0%)

@firebase/firestore/memory

Type Base (0a91a90) Head (2892d3b) Diff

browser 217 kB 217 kB +4 B (+0.0%)

esm2017 173 kB 173 kB +4 B (+0.0%)

module 217 kB 217 kB +4 B (+0.0%)

react-native 173 kB 173 kB +4 B (+0.0%)

`@firebase/firestore/memory-bundle`

Type	Base (`0a91a90`)	Head (`2892d3b`)	Diff
browser	225 kB	225 kB	+5 B (+0.0%)
esm2017	177 kB	177 kB	+5 B (+0.0%)
main	322 kB	322 kB	+1 B (+0.0%)
module	225 kB	225 kB	+5 B (+0.0%)
react-native	177 kB	177 kB	+5 B (+0.0%)

`@firebase/storage`

Type	Base (`0a91a90`)	Head (`2892d3b`)	Diff
browser	64.1 kB	66.4 kB	+2.31 kB (+3.6%)
esm2017	55.2 kB	55.6 kB	+391 B (+0.7%)
main	55.8 kB	56.1 kB	+300 B (+0.5%)
module	64.1 kB	66.4 kB	+2.31 kB (+3.6%)

@firebase/storage-compat

Type Base (0a91a90) Head (2892d3b) Diff

main 29.3 kB 29.4 kB +118 B (+0.4%)
@firebase/storage-exp

Type Base (0a91a90) Head (2892d3b) Diff

browser 51.9 kB 54.9 kB +2.97 kB (+5.7%)

main 53.3 kB 54.6 kB +1.31 kB (+2.5%)

module 51.9 kB 54.9 kB +2.97 kB (+5.7%)

`firebase`

Type	Base (`0a91a90`)	Head (`2892d3b`)	Diff
firebase-app.js	22.1 kB	22.1 kB	+3 B (+0.0%)
firebase-firestore.js	337 kB	337 kB	+4 B (+0.0%)
firebase-firestore.memory.js	271 kB	271 kB	+4 B (+0.0%)
firebase-performance-standalone.es2017.js	73.5 kB	73.5 kB	+2 B (+0.0%)
firebase-performance-standalone.js	49.9 kB	49.9 kB	+2 B (+0.0%)
firebase-storage.js	45.0 kB	46.4 kB	+1.41 kB (+3.1%)
firebase.js	896 kB	897 kB	+1.42 kB (+0.2%)

Test Logs

Base (0a91a906): https://github.com/firebase/firebase-js-sdk/actions/runs/1145700882
Head (2892d3bb): https://github.com/firebase/firebase-js-sdk/actions/runs/1151277693

google-oss-bot · 2021-06-03T21:46:53Z

Size Analysis Report

Affected Products

No changes between base commit (0a91a90) and head commit (2892d3b).

Test Logs

github-actions · 2021-08-13T20:25:58Z

Changeset File Check ⚠️

Changeset formatting error in following file:

Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
If this change doesn't need a release, run `changeset add --empty`.

This adds a Node and a Browser specific build so we can have getStream() in Node and getBlob() in browsers

schmidt-sebastian · 2021-10-05T22:27:47Z

packages/storage/src/platform/browser/connection.ts

+    return super
+      .send(url, method, body, headers)
+      .then(() => (this.xhr_.response as Blob).arrayBuffer())
+      .then(data => {


Need to ensure this never throws

schmidt-sebastian force-pushed the mrschmidt/getbytes branch from 4dd2790 to 261f5d1 Compare August 13, 2021 20:23

schmidt-sebastian force-pushed the mrschmidt/getbytes branch 3 times, most recently from ca48914 to 2e29beb Compare August 19, 2021 19:37

schmidt-sebastian changed the title ~~WIP: getBytes~~ getBytes Aug 19, 2021

schmidt-sebastian requested a review from hsubox76 August 19, 2021 19:37

schmidt-sebastian assigned hsubox76 Aug 19, 2021

schmidt-sebastian marked this pull request as ready for review August 19, 2021 19:38

schmidt-sebastian requested review from Feiyang1 and hiranya911 as code owners August 19, 2021 19:38

Feiyang1 mentioned this pull request Aug 21, 2021

Firebase Storage READ security rules: almost pointless, as currently implemented. #5342

Open

schmidt-sebastian force-pushed the mrschmidt/getbytes branch from ee67537 to ad2374e Compare September 3, 2021 20:22

google-oss-bot added the doc-changes PRs that affect docs label Sep 3, 2021

github-actions bot assigned egilmorez Sep 3, 2021

schmidt-sebastian mentioned this pull request Sep 9, 2021

Misc source cleanup for Firebase Storage #5467

Merged

Misc source cleanup for Firebase Storage

de302d7

schmidt-sebastian mentioned this pull request Sep 9, 2021

Add Node build for Firebase Storage #5468

Merged

schmidt-sebastian added 3 commits September 9, 2021 09:47

Add Node build for Firebase Storage

00cfe38

This adds a Node and a Browser specific build so we can have getStream() in Node and getBlob() in browsers

Remove ConnectionPool

d327c9e

Remove await

2fa1e3b

schmidt-sebastian unassigned egilmorez and hsubox76 Sep 9, 2021

schmidt-sebastian mentioned this pull request Sep 9, 2021

Remove ConnectionPool #5469

Merged

schmidt-sebastian added 3 commits September 9, 2021 11:43

Merge

a9292c6

Formatting

9184420

Merge branch 'mrschmidt/nodebuild' into mrschmidt/all

e6aa3e0

schmidt-sebastian force-pushed the mrschmidt/getbytes branch from a2a58f6 to 4d58d30 Compare September 9, 2021 19:33

Add getBytes()/getBlob()/getStream()

9c7e6b9

schmidt-sebastian force-pushed the mrschmidt/getbytes branch from df4bb83 to 9c7e6b9 Compare September 10, 2021 21:21

Update API reports

1099618

schmidt-sebastian commented Oct 5, 2021

View reviewed changes

schmidt-sebastian closed this Oct 27, 2021

firebase locked and limited conversation to collaborators Nov 27, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

getBytes #4973

getBytes #4973

schmidt-sebastian commented Jun 3, 2021 •

edited

Loading

changeset-bot bot commented Jun 3, 2021 •

edited

Loading

google-oss-bot commented Jun 3, 2021 •

edited

Loading

`@firebase/app`

`@firebase/firestore`

`@firebase/firestore-compat`

`@firebase/firestore/bundle`

`@firebase/firestore/memory`

`@firebase/firestore/memory-bundle`

`@firebase/storage`

`@firebase/storage-compat`

`@firebase/storage-exp`

`firebase`

google-oss-bot commented Jun 3, 2021 •

edited

Loading

Affected Products

Test Logs

github-actions bot commented Aug 13, 2021 •

edited

Loading

schmidt-sebastian Oct 5, 2021

getBytes #4973

getBytes #4973

Conversation

schmidt-sebastian commented Jun 3, 2021 • edited Loading

changeset-bot bot commented Jun 3, 2021 • edited Loading

⚠️ No Changeset found

google-oss-bot commented Jun 3, 2021 • edited Loading

Binary Size Report

Affected SDKs

@firebase/app

@firebase/firestore

@firebase/firestore-compat

@firebase/firestore/bundle

@firebase/firestore/memory

@firebase/firestore/memory-bundle

@firebase/storage

@firebase/storage-compat

@firebase/storage-exp

firebase

Test Logs

google-oss-bot commented Jun 3, 2021 • edited Loading

Size Analysis Report

Affected Products

Test Logs

github-actions bot commented Aug 13, 2021 • edited Loading

Changeset File Check ⚠️

schmidt-sebastian Oct 5, 2021

Choose a reason for hiding this comment

schmidt-sebastian commented Jun 3, 2021 •

edited

Loading

changeset-bot bot commented Jun 3, 2021 •

edited

Loading

google-oss-bot commented Jun 3, 2021 •

edited

Loading

`@firebase/app`

`@firebase/firestore`

`@firebase/firestore-compat`

`@firebase/firestore/bundle`

`@firebase/firestore/memory`

`@firebase/firestore/memory-bundle`

`@firebase/storage`

`@firebase/storage-compat`

`@firebase/storage-exp`

`firebase`

google-oss-bot commented Jun 3, 2021 •

edited

Loading

github-actions bot commented Aug 13, 2021 •

edited

Loading