Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error when initializing firebase on service worker #8414

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

jbalidiong
Copy link
Contributor

Updated how app-compat checks the global scope. The getGlobal() checks the existence of self, window, and also global.

Fixes #8409

@jbalidiong jbalidiong requested a review from a team as a code owner August 8, 2024 11:07
Copy link

changeset-bot bot commented Aug 8, 2024

🦋 Changeset detected

Latest commit: 4b53371

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@firebase/app-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jbalidiong jbalidiong requested review from a team as code owners August 8, 2024 11:09
@hsubox76
Copy link
Contributor

hsubox76 commented Aug 8, 2024

Thanks for investigating and fixing this!

@hsubox76 hsubox76 merged commit 1601572 into firebase:main Aug 8, 2024
36 of 39 checks passed
This was referenced Aug 13, 2024
@firebase firebase locked and limited conversation to collaborators Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firebase messaging service worker failed to load v10.12.5 script
2 participants