Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair devsite docs #8447

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Repair devsite docs #8447

merged 1 commit into from
Aug 21, 2024

Conversation

dlarocque
Copy link
Contributor

I ran yarn docgen:all and noticed there were some changes. These should have been caught by our docgen check job, I'm not sure why they weren't.

@dlarocque dlarocque requested a review from a team as a code owner August 21, 2024 15:17
Copy link

changeset-bot bot commented Aug 21, 2024

⚠️ No Changeset found

Latest commit: c27537e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

One question about the TOC.

docs-devsite/_toc.yaml Show resolved Hide resolved
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for noting and fixing!

@dlarocque dlarocque merged commit fa0ed08 into main Aug 21, 2024
35 checks passed
@dlarocque dlarocque deleted the dl/repair-docs-devsite branch August 21, 2024 16:50
@firebase firebase locked and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants