-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Firebase JS 10 compat #1032
Conversation
We did make a couple of breaking changes in v10 - https://firebase.google.com/support/release-notes/js#authentication Can we make sure these do not affect our current usage in UI Web? I assume CI passing will cover it, but worth manually testing/auditing. |
Good point, on first glance I thought the only Auth changes were related to React Native, but the
The tests mock RecaptchaVerifier so they won't catch errors with the new API: firebaseui-web/javascript/testing/recaptchaverifier.js Lines 28 to 42 in de8a5b0
And our externs will need to be redefined:
Will drop this back to draft for now. We may have to do a major version bump to support v10 |
From what I can tell, the breaking change in v10 doesn't affect compat. The compat source still has the old API: https://github.com/firebase/firebase-js-sdk/blob/503ca1eda8b0df1af9f039257117d973ec8c9f45/packages/auth-compat/src/recaptcha_verifier.ts#L25-L34 I'm testing now in the demo app to confirm Update: Phone auth in the demo app works! |
Firebase JS
10.0.0
release notesAdding Firebase JS SDK v10 compat as a valid peer version in addition to v9. Updating demos to v10.
FirebaseUI still uses compat instead of the modular SDK, this just allows v10 to be used as a peer dependency.