Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firebase_storage_web): fix Error: Unexpected null value. when metadata.timeCreated or metadata.updated #10577

Merged

Conversation

nilsreichardt
Copy link
Contributor

Description

I had the issue when uploading a file and accessing taskSnapshot.metadata that a Error: Unexpected null value. was thrown. With a bit debugging I found out that at the beginning of the upload the metadata.timeCreated and (or? I'm not sure) metadata.updated are null. Because of the ! the was Error: Unexpected null value. thrown.

Related Issues

.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone Lyokone self-assigned this Mar 9, 2023
@Lyokone
Copy link
Contributor

Lyokone commented Mar 9, 2023

Hey 👋
Thanks, effectively according to documentation it can be null.

@russellwheatley russellwheatley merged commit 6eb235b into firebase:master Mar 9, 2023
@nilsreichardt
Copy link
Contributor Author

Yes I know that it can be null and this is also documented in FlutterFire. But it's impossible to check if it's null. Even taskSnapshot.metadata == null throws the exception because metadata is accessed and inside of metadata is the error thrown.

@firebase firebase locked and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants