[firebase_crashlytics] Migrate to new Crashlytics SDK #2288

axel-op · 2020-04-02T16:55:58Z

Description

This PR updates the Crashlytics implementation to use the new SDK, which doesn't use the Fabric SDK anymore: https://firebase.google.com/docs/crashlytics/get-started-new-sdk.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
No, this is not a breaking change.

MaikuB · 2020-04-04T00:21:25Z

@axel-op I believe the title of the PR needs amending to start with [firebase_crashlytics] instead of [crashlytics] as it's the name of the plugin that should be used

axel-op · 2020-04-04T01:34:37Z

@MaikuB Thanks, it's done. What do you think of the PR?

MaikuB · 2020-04-04T11:34:12Z

@axel-op I'm not familiar with the APIs to comment. Came across your PR as another member in the community mentioned it :)

packages/firebase_crashlytics/lib/src/firebase_crashlytics.dart

packages/firebase_crashlytics/darwin/Classes/FirebaseCrashlyticsPlugin.m

axel-op · 2020-04-08T01:46:16Z

I'll definitely need help for the iOs part.

workerbee22 · 2020-04-14T07:03:25Z

What do we need to do to get this moving ... it's already very urgent.

axel-op · 2020-04-14T12:57:37Z

I have to update the README file

workerbee22 · 2020-04-17T06:46:24Z

Wow ... @axel-op great progress 🎉🎉🎉

workerbee22

Looking good, just some beta version updates.

packages/firebase_crashlytics/android/build.gradle

packages/firebase_crashlytics/example/android/build.gradle

axel-op · 2020-04-19T15:15:57Z

Looks like they have moved to beta4 as per the official doco here

Thanks @workerbee22 for pointing that out :)

axel-op · 2020-04-19T15:18:51Z

@workerbee22 and @creativecreatorormaybenot is everything OK for you?

creativecreatorormaybenot · 2020-04-19T16:31:18Z

It seems as though my feedback has been addressed 👍🏼
Need some testing now to confirm that everything works as expected and a maintainer to take a look at this.

axel-op · 2020-04-19T18:13:58Z

Well, I was just asking for your opinion, since I knew you would answer much faster ;)

workerbee22

LGTM

axel-op · 2020-06-01T02:43:31Z

@axel-op I'm skeptical about that as all that should already be handled and a lot of plugins that wrap around native SDKs work in a similar way without issues. I would think there's something else going on there that I wouldn't read too much into it unless a complete sample app can be provided to demonstrate it's needed. For what it's worth I work on an app that hasn't needed those steps and would expect it to be a more widespread issue if it was needed

Noted 👍

MaikuB · 2020-06-01T02:54:40Z

@MaikuB Also while testing I had to update my AppDelegate file like so. But I'm really not an expert in iOS development, so I'd really like to have a confirmation from an iOS developer.

If that's the case then it worth debugging the plugin further as it could mean that this isn't being called.

One alternative is to have the plugin register to receive AppDelegate calls and call configure like you currently do in the example app's AppDelegate.swift file. This would (1) remove the need to have developers do it themselves and (2) more closely mirror the setup required by a native iOS app. An example of how to have the plugin register to receive these calls can be found here. Not sure if there was a reason why it wasn't originally done this way though

axel-op · 2020-06-01T03:07:58Z

@MaikuB Thanks! I'm not sure I should make these changes right now, as I believe the current rework by the people from Invertase will probably bring some important changes to the native part of all Firebase plugins, as this comment suggests.

Ehesp · 2020-06-01T10:57:28Z

With the upcoming changes, firebase_core will be required for other plugins to work. Part of the setup steps will be to ensure that the user adds these lines into your AppDelegate file.

We should have a PR up soon which overhauls Core, along with other changes (CI, tests etc) so it'd make more sense to sync this work up with that.

MaikuB · 2020-06-01T11:02:23Z

@Ehesp has the team looked at minimising the amount of code users need to put into their AppDelegate file as well? Flutter already provides mechanisms for plugins to receive AppDelegate calls. It looks like there's potential opportunity to do that in this PR as well

Ehesp · 2020-06-01T12:17:42Z

Yep that was a terrible example, we're doing that already - will link to the PR when it's up.

thomas-stockx · 2020-06-10T14:56:15Z

This is slowly getting urgent as the Firebase team is sending out automated emails in regards to the Fabric Crashlytics SDK now being officially deprecated and will stop working on November 15, 2020.

jpelgrim · 2020-06-17T14:57:23Z

packages/firebase_crashlytics/README.md

+  implementation 'com.google.firebase:firebase-analytics:17.4.0'
+
+  // Add the Firebase SDK for Crashlytics.
+  implementation 'com.google.firebase:firebase-crashlytics:17.0.0'


This dependency is already in the firebase_crashlytics package ./android/build.gradle file, right? We don't need to add it to our Flutter app build.gradle file IMO.

Update: Works fine without it in my case. I don't think the whole fourth step is needed. It's even a bit confusing and misleading to add the firebase-analytics dependency too here since it's not necessary for Firebase Crashlytics to work.

Yeah if it's already a dependency used by the plugin then developers shouldn't need to add it to their app's build.gradle file

cc @axel-op

Ditto for the firebase_analytics ! I don't like the way the official documentation like this: https://firebase.google.com/docs/flutter/setup?platform=ios

Encourages other packages. It just leads to possible reader confusion.

This will be updated when the package will depend on the new versions of firebase_core.

gaetschwartz · 2020-07-02T17:06:04Z

Do we have any updates on the status of this PR @axel-op ? I can help if needed but I'm pretty sure this PR is becoming quite urgent and it would be great to be able to push it asap ;)

tillchen · 2020-07-02T21:14:17Z

Any updates? The discrepancy of documentations is very confusing now.

axel-op · 2020-07-03T01:20:03Z

Do we have any updates on the status of this PR @axel-op ? I can help if needed but I'm pretty sure this PR is becoming quite urgent and it would be great to be able to push it asap ;)

I'm gonna work on it this weekend.

axel-op · 2020-07-05T11:02:40Z

I think that we should now wait for the new releases of firebase_core that should be published next week.

ened · 2020-07-07T09:28:51Z

@axel-op @Ehesp What is a good way to support NDK crash reports using the new SDK? See this page for a example on the native integration: https://firebase.google.com/docs/crashlytics/ndk-reports

It seems that integration of NDK crash reports requires a dependency change and some additional gradle configuration. Perhaps it is enough to mention it in the README?

donguseo · 2020-07-15T23:21:01Z

I think that we should now wait for the new releases of firebase_core that should be published next week.

firebase_core-v0.5.0-dev.1 is released! When will this pr be merged?

Salakar · 2020-07-23T18:44:40Z

Hey everyone, good news; Crashlytics has been bumped to the top of the priority list on the roadmap #2582 - so we'll be looking at this next.

What would be helpful is if anyone that has been using this PR in production could respond here if there's still any outstanding issues they've discovered while using the code in this PR, thanks!

@axel-op if you're willing, do you have any form of messaging so we can chat quicker and help get this PR merged quicker? I'm Salakar#1337 on Discord, or @mikediarmid on Twitter if any of these work for you.

Ehesp · 2020-07-24T09:38:55Z

Hey all 👋 I've started the process of breaking out the work done by @axel-op into a federated plugin setup, along with some QOL updates to get it ready for review and release.

The PR is in-progress here https://github.com/invertase/flutterfire/pull/41

Thanks again for this contribution @axel-op 🥳

axel-op · 2020-07-24T14:11:03Z

@Ehesp Thanks ☺️

gaetschwartz · 2020-08-03T10:08:45Z

Any updates on this PR ? ☺

Ehesp · 2020-08-03T11:45:01Z

Nope, currently going through updates and review still.

gaetschwartz · 2020-08-16T22:40:04Z

Is there progress on this PR ? And is there any way for me to help ? Would gladly help is you need some ;)

yringler · 2020-08-28T05:24:43Z

@blaxou , the PR is under active development, but at a new location https://github.com/invertase/flutterfire/pull/41. Latest activity was 4 days ago.

Salakar · 2020-09-01T09:40:50Z

Closing in favour of #3420

axel-op requested review from collinjackson and kroikie as code owners April 2, 2020 16:55

googlebot added the cla: yes label Apr 2, 2020

axel-op changed the title ~~[crashlytics] Migrate to new Crashlytics SDK~~ [firebase_crashlytics] Migrate to new Crashlytics SDK Apr 4, 2020

axel-op force-pushed the crashlytics-new-sdk branch from 14966df to b22a659 Compare April 6, 2020 17:26

creativecreatorormaybenot reviewed Apr 7, 2020

View reviewed changes

packages/firebase_crashlytics/lib/src/firebase_crashlytics.dart Show resolved Hide resolved

axel-op commented Apr 8, 2020

View reviewed changes

packages/firebase_crashlytics/darwin/Classes/FirebaseCrashlyticsPlugin.m Outdated Show resolved Hide resolved

creativecreatorormaybenot reviewed Apr 8, 2020

View reviewed changes

packages/firebase_crashlytics/darwin/Classes/FirebaseCrashlyticsPlugin.m Show resolved Hide resolved

axel-op force-pushed the crashlytics-new-sdk branch from 5de1034 to 748633d Compare April 8, 2020 01:36

axel-op marked this pull request as draft April 8, 2020 22:05

axel-op force-pushed the crashlytics-new-sdk branch 2 times, most recently from 2f337ad to d49998a Compare April 14, 2020 11:49

axel-op force-pushed the crashlytics-new-sdk branch 2 times, most recently from 8ec938a to 5f88c57 Compare April 15, 2020 21:42

workerbee22 suggested changes Apr 17, 2020

View reviewed changes

packages/firebase_crashlytics/android/build.gradle Outdated Show resolved Hide resolved

packages/firebase_crashlytics/example/android/build.gradle Outdated Show resolved Hide resolved

axel-op force-pushed the crashlytics-new-sdk branch from 5f88c57 to 08e56dd Compare April 19, 2020 15:14

axel-op marked this pull request as ready for review April 20, 2020 17:34

workerbee22 approved these changes Apr 22, 2020

View reviewed changes

axel-op mentioned this pull request Apr 22, 2020

[firebase_crashlytics] Add missing documentation for android installation in README.md #2025

Closed

13 tasks

Update CHANGELOG

324dcf6

jpelgrim reviewed Jun 17, 2020

View reviewed changes

axel-op added 3 commits July 4, 2020 23:14

Merge remote-tracking branch 'upstream/master' into crashlytics-new-sdk

1ae9cab

Send logs and keys are they are set

0c883fa

Update tests

66d2d14

axel-op force-pushed the crashlytics-new-sdk branch from f9100e2 to 66d2d14 Compare July 4, 2020 22:21

Salakar mentioned this pull request Sep 1, 2020

feat(firebase_crashlytics): rework #3420

Merged

13 tasks

Salakar closed this Sep 1, 2020

firebase locked and limited conversation to collaborators Oct 2, 2020

[firebase_crashlytics] Migrate to new Crashlytics SDK #2288

[firebase_crashlytics] Migrate to new Crashlytics SDK #2288

Conversation

axel-op commented Apr 2, 2020 • edited Loading

Description

Related Issues

Checklist

Breaking Change

MaikuB commented Apr 4, 2020

axel-op commented Apr 4, 2020

MaikuB commented Apr 4, 2020

axel-op commented Apr 8, 2020

workerbee22 commented Apr 14, 2020

axel-op commented Apr 14, 2020

workerbee22 commented Apr 17, 2020

workerbee22 left a comment

Choose a reason for hiding this comment

axel-op commented Apr 19, 2020

axel-op commented Apr 19, 2020

creativecreatorormaybenot commented Apr 19, 2020

axel-op commented Apr 19, 2020

workerbee22 left a comment

Choose a reason for hiding this comment

axel-op commented Jun 1, 2020

MaikuB commented Jun 1, 2020

axel-op commented Jun 1, 2020

Ehesp commented Jun 1, 2020

MaikuB commented Jun 1, 2020

Ehesp commented Jun 1, 2020

thomas-stockx commented Jun 10, 2020

jpelgrim Jun 17, 2020 • edited Loading

Choose a reason for hiding this comment

MaikuB Jun 18, 2020 • edited Loading

Choose a reason for hiding this comment

workerbee22 Jun 22, 2020

Choose a reason for hiding this comment

axel-op Jul 7, 2020

Choose a reason for hiding this comment

gaetschwartz commented Jul 2, 2020

tillchen commented Jul 2, 2020

axel-op commented Jul 3, 2020

axel-op commented Jul 5, 2020 • edited Loading

ened commented Jul 7, 2020

donguseo commented Jul 15, 2020 • edited Loading

Salakar commented Jul 23, 2020 • edited Loading

Ehesp commented Jul 24, 2020

axel-op commented Jul 24, 2020

gaetschwartz commented Aug 3, 2020

Ehesp commented Aug 3, 2020

gaetschwartz commented Aug 16, 2020

yringler commented Aug 28, 2020

Salakar commented Sep 1, 2020

axel-op commented Apr 2, 2020 •

edited

Loading

jpelgrim Jun 17, 2020 •

edited

Loading

MaikuB Jun 18, 2020 •

edited

Loading

axel-op commented Jul 5, 2020 •

edited

Loading

donguseo commented Jul 15, 2020 •

edited

Loading

Salakar commented Jul 23, 2020 •

edited

Loading