[firebase_remote_config] Fix Future already completed RemoteConfig.instance #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collinjackson
changed the title
Closed
12 tasks
kroikie
approved these changes
Aug 30, 2019
|
I still get the error with this merge request 🤔 |
|
@IchordeDionysos would you mind filling an issue with the details of what you are seeing so we can have a closer look? |
|
@collinjackson @kroikie This issue does not seem to be fixed by this pull request: #195 |
13 tasks
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates flutter/plugins#1966 by @IchordeDionysos
I ended up rewriting it a bit.
Note: It seems the plugin was working fine and the behavior is covered by a test, but there was a spurious error message in the logs. This PR is removing the error message in the logs, and I don't think I can easily cover that in a test.
Fixes flutter/flutter#38060