-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: organize melos for full local testing, minor fixes so complete runs quickly pass #4331
Conversation
packages/firebase_admob/example/test_driver/firebase_admob_e2e.dart
Outdated
Show resolved
Hide resolved
packages/firebase_admob/example/test_driver/firebase_admob_e2e_test.dart
Outdated
Show resolved
Hide resolved
packages/firebase_messaging/firebase_messaging/example/test_driver/instance_e2e.dart
Outdated
Show resolved
Hide resolved
packages/firebase_ml_vision/example/test_driver/firebase_ml_vision_e2e.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes
c9155fe
to
6186083
Compare
@Salakar down to 4 commits now, with a cleaner ignores list. Suggest handling global ignores issue as a separate item |
6186083
to
67d133b
Compare
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
67d133b
to
38645d5
Compare
Okay, I rebased this to upstream/master and it seemed like for safety's sake I should include the commit that fixes firebase_ml_vision so it works with the final 25.x.x Android BoM (note that commit is battle-tested from react-native-firebase - you may check related links on it - it is ugly but correct) I also fixed the issue where from a clean checkout the Unless auth rejects you for too many requests but that's out of my control 🤷 I'd love to see this or something like this integrated, it is the test harness I use to prove the firebase-ios-sdk v7+ / firebase-android-sdk v26+ #4249 work and auth emulator work #4263 Cheers :-) |
Until all the E2E workflow components that rely on network resources are wrapped in re-tries, the e2e jobs here will be subject to flakiness, it's not the PR that caused the firebase_messaging android failure, but I can't re-trigger that
|
also add parallelism to melos targets for full machine utilization during local quality checks - firebase_ml_custom currently has an intractable build error due to tflite plugin needing TensorFlowLiteC 2.2.0 while up to date FirebaseMLVision needs 2.3.0 - firebase_admob and firebase_ml_vision do not have e2e tests for their examples
The intention is to easily return to a fresh-checkout status so that developers can verify their environment will roughly match CI when it runs, and thus expose any local problems Incidentally, local example Podfiles are deleted here, as they are the source of CI-versus-local-environment differences and ensuing CI failures
38645d5
to
1254de7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
As a new contributor, it is difficult to say that you have a correct working environment before making your first change, or that after your change you have not broken anything.
The goal of this PR is purely local test oriented then
Related Issues
This is related to the forward-port PR #4249 but these commits may be considered independently and immediately to help developers now, and to shrink that PR to it's core purpose
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?