fix(build): Use one version of firebase SDKs everywhere #4332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
mikehardy
force-pushed
the
use-one-version-everywhere
branch
from
0c5b087
to
34cbe4c
Compare
- depend on firebase_core in preference to Firebase/Core (or CoreOnly) - do not specify override versions where unnecessary - include Firebase SDK version override logic in all podspecs
mikehardy
force-pushed
the
use-one-version-everywhere
branch
from
34cbe4c
to
e72b03b
Compare
mikehardy
force-pushed
the
use-one-version-everywhere
branch
from
e72b03b
to
031dd44
Compare
|
Admob Android CI failed because there are no retries on network fetches. I've noted that before 😄 and have a fair bit of experience de-flaking these things, if the style I proposed for this repo could work then I could finish building it out and CI would be more reliable: #4265 |
Salakar
approved these changes
Jan 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The logic to specify a baseline firebase SDK version and accept an override for same is fairly standardized across the repository but not applied uniformly or used everywhere
This PR harmonizes the logic across the repository, depends on firebase_core as needed in place of lower-level direct pod dependencies on ios and uses the BoM and core pod versions where ever possible
Related Issues
This is related to the forward port PR #4249 but is not a core part of that change, rather it makes that change easier while being independently correct and useful, so I'm submitting it separately for immediate consideration in order to shrink that PR and get feedback on utility
Checklist
///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?