refactor: Migrate firebase auth to nnbd #4633

rrousselGit · 2021-01-12T08:56:17Z

Description

This migrate firebase_auth to non-nullable types

Do not merge before firebase_core is migrated

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

I read the Contributor Guide and followed the process outlined there for submitting PRs.
My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
All existing and new tests are passing.
I updated/added relevant documentation (doc comments with ///).
The analyzer (flutter analyze) does not report any problems on my PR.
I read and followed the Flutter Style Guide.
I signed the CLA.
I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
No, this is not a breaking change.

google-cla · 2021-01-12T08:57:02Z

☹️ Sorry, but only Googlers may change the label cla: yes.

rrousselGit · 2021-01-12T09:33:58Z

packages/firebase_auth/firebase_auth_platform_interface/lib/src/firebase_auth_exception.dart

-  /// Complete error message.
-  final String message;
+  FirebaseAuthException({
+    String? message,


"message" is optional/nullable in base-classes, and some places passed null as message, so I removed the required

required removal makes sense 👍

rrousselGit · 2021-01-12T09:39:07Z

...s/firebase_auth/firebase_auth_platform_interface/lib/src/method_channel/utils/exception.dart

  if (exception is! Exception || exception is! PlatformException) {
+    // TODO(rrousselGit): Is this dead code?
    return exception;


This code cannot be assigned to Exception, so I changed the return type to Object.

But that raise a question: Why do we even need this code? It probably was never reached before, as we'd otherwise get a "XX cannot be assigned to Exception" thrown

I can't think of any reason why this was needed, @Ehesp might be able to confirm if around

rrousselGit · 2021-01-12T09:40:40Z

...s/firebase_auth/firebase_auth_platform_interface/lib/src/method_channel/utils/exception.dart

@@ -10,13 +10,13 @@ import '../../firebase_auth_exception.dart';

 /// Catches a [PlatformException] and converts it into a [FirebaseAuthException]
 /// if it was intentionally caught on the native platform.
-Exception convertPlatformException(Object exception) {
+Object convertPlatformException(Object exception) {
  if (exception is! Exception || exception is! PlatformException) {


PlatformException is an Exception so the first condition isn't needed

rrousselGit · 2021-01-12T09:41:42Z

...s/firebase_auth/firebase_auth_platform_interface/lib/src/method_channel/utils/exception.dart

-  String /*!*/ message = platformException.message;
-  String email;
-  AuthCredential credential;
+  String? message = platformException.message;


Related to the previous comment about message now being nullable

I believe the /*!*/ was erroneous

rrousselGit · 2021-01-12T13:37:09Z

...ase_auth_platform_interface/test/method_channel_tests/method_channel_firebase_auth_test.dart


        final additionalUserInfo = result.additionalUserInfo;
-        expect(additionalUserInfo, isA<Object>());
+        expect(additionalUserInfo, isNull);


isA<Object> is always true. Using isNull since that is the current behaviour, but could be wrong

rrousselGit · 2021-01-12T13:38:07Z

...ase_auth_platform_interface/test/method_channel_tests/method_channel_firebase_auth_test.dart

+              verificationCompleted: (_) {},
+              verificationFailed: (_) {},
+              codeSent: (_, __) {},
+              codeAutoRetrievalTimeout: (_) {},
+              timeout: testTimeout,
+              autoRetrievedSmsCodeForTesting: testSmsCode,


Not sure if this change is expected, or if some parameters could be nullable?

rrousselGit · 2021-01-12T13:41:48Z

packages/firebase_auth/firebase_auth_platform_interface/test/mock.dart

+  String type,
+  void Function() testMethod,
+) async {
+  await expectLater(


Same behaviour, but much better error message

There are many tests that should be changed to follow this pattern

rrousselGit · 2021-01-12T13:44:01Z

...es/firebase_auth/firebase_auth_web/lib/src/firebase_auth_web_recaptcha_verifier_factory.dart

          .add(DivElement()..id = _kInvisibleElementId);

      element = _kInvisibleElementId;
    } else {
      parameters['size'] = convertRecaptchaVerifierSize(size);
      parameters['theme'] = convertRecaptchaVerifierTheme(theme);

-      Element el = window.document.getElementById(container);


It didn't feel correct to do nothing with el besides an assertion. This change no-longer calls getElementById when the asserts are removed

into migrate_firebase_auth_to_nnbd

…ersion not NNBD

…NNBD

google-cla · 2021-01-20T13:09:54Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

Salakar · 2021-01-20T13:35:57Z

@googlebot I consent.

into migrate_firebase_auth_to_nnbd

rrousselGit added 6 commits January 11, 2021 15:29

Migrate firebase_auth_platform_interface

b3ec000

migrate firebase_auth

9a33d44

migrate firebase_auth_web

fe29377

Enable extra lint rules for firebase_auth

63d1795

Merge branch 'master' of https://github.com/FirebaseExtended/flutterfire

0501c37

remove duplicate key in pubspecs

42a1b2d

google-cla bot added the cla: yes label Jan 12, 2021

rrousselGit added blocked: do-not-merge PR blocked externally and removed cla: yes labels Jan 12, 2021

google-cla bot added the cla: yes label Jan 12, 2021

rrousselGit commented Jan 12, 2021

View reviewed changes

self review

9039f78

rrousselGit changed the title ~~Migrate firebase auth to nnbd~~ chrore: Migrate firebase auth to nnbd Jan 12, 2021

rrousselGit changed the title ~~chrore: Migrate firebase auth to nnbd~~ chore: Migrate firebase auth to nnbd Jan 12, 2021

rrousselGit commented Jan 12, 2021

View reviewed changes

rrousselGit added 3 commits January 12, 2021 13:47

Self review

77f5d3c

Add headers to lint files

2c6eca8

Merge branch 'master' of https://github.com/FirebaseExtended/flutterfire

d0bc2c5

into migrate_firebase_auth_to_nnbd

Salakar changed the title ~~chore: Migrate firebase auth to nnbd~~ refactor: Migrate firebase auth to nnbd Jan 15, 2021

rrousselGit added 3 commits January 15, 2021 22:45

Merge branch 'master' of https://github.com/FirebaseExtended/flutterfire

6da5b6e

into migrate_firebase_auth_to_nnbd

remove dart=2.9 comments

5078da9

Fix all tests

7335b1c

rrousselGit marked this pull request as ready for review January 19, 2021 12:02

rrousselGit and others added 5 commits January 19, 2021 12:25

Merge branch 'master' of https://github.com/FirebaseExtended/flutterfire

d2f04ab

into migrate_firebase_auth_to_nnbd

add http null-safe as git dependency

5f7caf7

(examples) override http_parser due to test -> shelf -> http_parser v…

155cf62

…ersion not NNBD

override http_parser due to test -> shelf -> http_parser version not …

2592352

…NNBD

update auth's core versions

4d81ff2

google-cla bot added cla: no and removed cla: yes labels Jan 20, 2021

google-cla bot added cla: yes and removed cla: no labels Jan 20, 2021

rrousselGit added 3 commits January 20, 2021 14:46

Merge branch 'master' of https://github.com/FirebaseExtended/flutterfire

1396464

into migrate_firebase_auth_to_nnbd

use dev melos

a7563cb

fix compilation error

166eba2

rrousselGit force-pushed the migrate_firebase_auth_to_nnbd branch from d324b34 to 166eba2 Compare January 20, 2021 15:18

add dependency_override for auth example

90f273b

rrousselGit force-pushed the migrate_firebase_auth_to_nnbd branch 2 times, most recently from 1aab645 to fd784b0 Compare January 20, 2021 16:45

remove http git dependency on performance/storage

eba3d64

rrousselGit force-pushed the migrate_firebase_auth_to_nnbd branch from fd784b0 to eba3d64 Compare January 20, 2021 16:59

rrousselGit added 3 commits January 20, 2021 17:12

use non-null-safe http version in packages other than auth

c223ec6

use melos 0.4.0-dev.2

c9ef678

remove null tests

004da73

rrousselGit force-pushed the migrate_firebase_auth_to_nnbd branch from 4d635d6 to 004da73 Compare January 20, 2021 22:10

fix auth web tests

f148e86

Salakar approved these changes Jan 21, 2021

View reviewed changes

rrousselGit merged commit 1e8f48a into master Jan 21, 2021

rrousselGit deleted the migrate_firebase_auth_to_nnbd branch January 21, 2021 12:20

mikehardy mentioned this pull request Jan 21, 2021

feat(firebase_auth): implement support for useEmulator #4263

Merged

10 tasks

firebase locked and limited conversation to collaborators Feb 21, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Migrate firebase auth to nnbd #4633

refactor: Migrate firebase auth to nnbd #4633

rrousselGit commented Jan 12, 2021

google-cla bot commented Jan 12, 2021

rrousselGit Jan 12, 2021

Salakar Jan 12, 2021

rrousselGit Jan 12, 2021

Salakar Jan 12, 2021 •

edited

Loading

rrousselGit Jan 12, 2021

rrousselGit Jan 12, 2021

rrousselGit Jan 12, 2021

rrousselGit Jan 12, 2021

rrousselGit Jan 12, 2021

rrousselGit Jan 12, 2021

Salakar Jan 12, 2021

google-cla bot commented Jan 20, 2021

Salakar commented Jan 20, 2021

refactor: Migrate firebase auth to nnbd #4633

refactor: Migrate firebase auth to nnbd #4633

Conversation

rrousselGit commented Jan 12, 2021

Description

Related Issues

Checklist

Breaking Change

google-cla bot commented Jan 12, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Salakar Jan 12, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

google-cla bot commented Jan 20, 2021

Salakar commented Jan 20, 2021

Salakar Jan 12, 2021 •

edited

Loading