chore: Migrate firebase_core to nnbd #4656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrousselGit
commented
Jan 13, 2021
Comment on lines
+38
to
+51
| Future<FirebaseAppPlatform> initializeApp({ | ||
| String? name, | ||
| FirebaseOptions? options, | ||
| }) async { | ||
| return FakeFirebaseAppPlatform(); | ||
| } | ||
|
|
||
| @override | ||
| FirebaseAppPlatform app([String name = defaultFirebaseAppName]) { | ||
| return null; | ||
| return FakeFirebaseAppPlatform(); | ||
| } | ||
|
|
||
| @override | ||
| List<FirebaseAppPlatform> get apps => null; | ||
| List<FirebaseAppPlatform> get apps => []; |
There was a problem hiding this comment.
These changes were necessary to make the tests compile. Afaik this doesn't matter but it'd be worth double checking that this doesn't change the behaviour of the related tests
Salakar
reviewed
Jan 14, 2021
rrousselGit
force-pushed
the
migrate_firebase_core_to_nnbd
branch
from
f3687e3
to
a47a75b
Compare
rrousselGit
force-pushed
the
migrate_firebase_core_to_nnbd
branch
from
40da1c4
to
03f904c
Compare
Salakar
reviewed
Jan 15, 2021
packages/firebase_core/firebase_core_platform_interface/lib/src/firebase_options.dart
Outdated
Show resolved
Hide resolved
Salakar
reviewed
Jan 15, 2021
packages/firebase_core/firebase_core_platform_interface/lib/src/firebase_options.dart
Outdated
Show resolved
Hide resolved
Salakar
reviewed
Jan 15, 2021
...base_core_platform_interface/test/method_channel_tests/method_channel_firebase_app_test.dart
Show resolved
Hide resolved
Salakar
reviewed
Jan 15, 2021
fix tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This migrates
firebase_core,firebase_core_platform_interfaceandfirebase_core_webto non-nullable type (but notfirebase_core/example)Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?