chore(macos,firestore): use precompiled frameworks in example app #4698
Conversation
Salakar
force-pushed
the
@salakar/macos-firestore-frameworks
branch
from
42164fd
to
d376f43
Compare
|
A related Ticket is also #3185 ([cloud_firestore] Xcode build extremely slow (Flutter macOS)) 👍 |
| @@ -1,4 +1,9 @@ | |||
| platform :osx, '10.12' | |||
| $FirebaseSDKVersion = '7.4.0' | |||
There was a problem hiding this comment.
I removed those in my one version pr, why add one back? Now you have this version to watch and bump even though core is mandatory. Better to remove this and fail fast if can't get version from core then inevitably take version skew or maintain it
There was a problem hiding this comment.
This isn't the same, this is the overriding sdk versions in a users Podfile thing as we need 7.4.0 for macOS support but we're currently on 7.3.0 🙂
https://firebase.flutter.dev/docs/overview#overriding-native-sdk-versions
There was a problem hiding this comment.
...instead of bumping firebase_core in the PR?
There was a problem hiding this comment.
We're in the middle of nullsafety migrations so didn't think it wise to touch anything that affects all packages and potentially cause issues/slow things down, this is meant to be a targeted PR that can be readressed after the nullsafety dust settles by bumping core - I should have left a todo comment 😩
There was a problem hiding this comment.
Will throw up another PR in bit that reworks this and bumps core, then it can be rebased after nullsafety and merged.
There was a problem hiding this comment.
That's understandable but a breadcrumb for sure. I will say that the 7.n.0 updates are trivial, if they can't just always be adopted firebase-ios-sdk did something wrong, and they haven't done that for a while. This particular one (7.3.0 to 7.4.0) was just fine in my experience on my work app (already live ;-) )
There was a problem hiding this comment.
This particular one (7.3.0 to 7.4.0) was just fine in my experience on my work app (already live ;-) )
Good to know, let's see what happens on the other PR with CI and perhaps we can merge it, maybe I'm worrying too much 😅
There was a problem hiding this comment.
Actually can't merge yet as it'd cause a feat version bump to all packages which we can't do yet with the nullsafety package versioning prereleases atm - still to be figured out.
I'll get the PR up still anyway.
Description
https://github.com/invertase/firestore-ios-sdk-frameworks should now be compatible with macOS, this PR adds it back in to improve build times on CI.
Note that this adds additional Ruby code to read the iOS SDK version that
firebase_coreuses so that the version used by https://github.com/invertase/firestore-ios-sdk-frameworks is always in sync with the version used byfirebase_coreand therefore your other Firebase plugins.Related Issues
#2751
invertase/firestore-ios-sdk-frameworks#11
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?