Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(messaging)!: migrate to NNBD #4909

Merged
merged 37 commits into from
Feb 2, 2021
Merged

refactor(messaging)!: migrate to NNBD #4909

merged 37 commits into from
Feb 2, 2021

Conversation

Ehesp
Copy link
Member

@Ehesp Ehesp commented Feb 2, 2021

Description

This PR converts the firebase_messaging plugin to non-null.

This PR also removes a number of deprecations:

  • [REMOVED] iOSNotificationSettings has been removed.
  • [REMOVED] requestNotificationPermissions - use requestPermission instead.
  • [REMOVED] autoInitEnabled() - use setAutoInitEnabled() instead.
  • [REMOVED] deleteInstanceID() - use deleteToken() instead.
  • [REMOVED] Calling FirebaseMessaging() - use FirebaseMessaging.instance instead.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@google-cla google-cla bot added the cla: yes label Feb 2, 2021
Ehesp
Ehesp commented Feb 2, 2021
View reviewed changes
packages/firebase_messaging/firebase_messaging/pubspec.yaml
@@ -5,28 +5,28 @@ homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/f
version: 8.0.0-dev.14

environment:
sdk: ">=2.12.0-0 <3.0.0"
sdk: '>=2.12.0-133.7.beta <3.0.0'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration tool applied these versions; can someone confirm what we're sticking with?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine

packages/firebase_messaging/firebase_messaging_platform_interface/pubspec.yaml
@@ -4,19 +4,19 @@ version: 1.0.0-dev.10
homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_messaging/firebase_messaging_platform_interface

environment:
sdk: ">=2.12.0-0 <3.0.0"
sdk: '>=2.12.0-133.7.beta <3.0.0'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration tool applied this; can someone confirm versions?

packages/firebase_messaging/firebase_messaging_web/pubspec.yaml
@@ -4,27 +4,27 @@ homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/f
version: 0.1.0-dev.5

environment:
sdk: ">=2.12.0-0 <3.0.0"
sdk: '>=2.12.0-133.7.beta <3.0.0'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO confirm version

rrousselGit
rrousselGit approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@rrousselGit rrousselGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor changes

packages/firebase_messaging/firebase_messaging/example/lib/main.dart Outdated Show resolved Hide resolved
packages/firebase_messaging/firebase_messaging/example/lib/permissions.dart Outdated Show resolved Hide resolved
packages/firebase_messaging/firebase_messaging/lib/src/messaging.dart Outdated Show resolved Hide resolved
packages/firebase_messaging/firebase_messaging/lib/src/messaging.dart Outdated Show resolved Hide resolved
packages/firebase_messaging/firebase_messaging/pubspec.yaml
@@ -5,28 +5,28 @@ homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/f
version: 8.0.0-dev.14

environment:
sdk: ">=2.12.0-0 <3.0.0"
sdk: '>=2.12.0-133.7.beta <3.0.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine

...g/firebase_messaging_platform_interface/lib/src/method_channel/method_channel_messaging.dart Show resolved Hide resolved
...g/firebase_messaging_platform_interface/lib/src/method_channel/method_channel_messaging.dart Outdated Show resolved Hide resolved
...g/firebase_messaging_platform_interface/lib/src/method_channel/method_channel_messaging.dart Outdated Show resolved Hide resolved
...se_messaging_platform_interface/test/method_channel_tests/method_channel_messaging_test.dart Outdated Show resolved Hide resolved
...ging_platform_interface/test/platform_interface_tests/platform_interface_messaging_test.dart Outdated Show resolved Hide resolved
@Ehesp Ehesp changed the title feat(firebase_messaging!): nnbd migration feat(firebase_messaging)!: nnbd migration Feb 2, 2021
@Salakar Salakar changed the title feat(firebase_messaging)!: nnbd migration refactor(firebase_messaging)!: nnbd migration Feb 2, 2021
Ehesp and others added 22 commits February 2, 2021 14:58
@Ehesp @Salakar
Update packages/firebase_messaging/firebase_messaging/example/pubspec…
19eb22c 
….yaml

Co-authored-by: Mike Diarmid <[email protected]>
@Ehesp @Salakar
Update packages/firebase_messaging/firebase_messaging/example/pubspec…
8a1df18 
….yaml

Co-authored-by: Mike Diarmid <[email protected]>
@Ehesp @Salakar
Update packages/firebase_messaging/firebase_messaging/pubspec.yaml
9bfe5fc 
Co-authored-by: Mike Diarmid <[email protected]>
@Ehesp @Salakar
Update packages/firebase_messaging/firebase_messaging/pubspec.yaml
39081a3 
Co-authored-by: Mike Diarmid <[email protected]>
@Ehesp @Salakar
Update packages/firebase_messaging/firebase_messaging/pubspec.yaml
5fa2839 
Co-authored-by: Mike Diarmid <[email protected]>
@Ehesp @Salakar
Update packages/firebase_messaging/firebase_messaging/pubspec.yaml
1fc66f6 
Co-authored-by: Mike Diarmid <[email protected]>
@Ehesp @Salakar
Update packages/firebase_messaging/firebase_messaging/pubspec.yaml
539bbaf 
Co-authored-by: Mike Diarmid <[email protected]>
@Ehesp @Salakar
Update packages/firebase_messaging/firebase_messaging_platform_interf…
20148c9 
…ace/pubspec.yaml

Co-authored-by: Mike Diarmid <[email protected]>
@Ehesp @Salakar
Update packages/firebase_messaging/firebase_messaging_platform_interf…
da699ed 
…ace/pubspec.yaml

Co-authored-by: Mike Diarmid <[email protected]>
@Ehesp @Salakar
Update packages/firebase_messaging/firebase_messaging_platform_interf…
6e62c67 
…ace/pubspec.yaml

Co-authored-by: Mike Diarmid <[email protected]>
@Ehesp @Salakar
Update packages/firebase_messaging/firebase_messaging_platform_interf…
877bb7f 
…ace/pubspec.yaml

Co-authored-by: Mike Diarmid <[email protected]>
@Ehesp @Salakar
Update packages/firebase_messaging/firebase_messaging_platform_interf…
4883b46 
…ace/pubspec.yaml

Co-authored-by: Mike Diarmid <[email protected]>
@Ehesp @Salakar
Update packages/firebase_messaging/firebase_messaging_web/pubspec.yaml
feb008c 
Co-authored-by: Mike Diarmid <[email protected]>
@Ehesp @Salakar
Update packages/firebase_messaging/firebase_messaging_web/pubspec.yaml
b6cec99 
Co-authored-by: Mike Diarmid <[email protected]>
@Ehesp @Salakar
Update packages/firebase_messaging/firebase_messaging_web/pubspec.yaml
aa2714f 
Co-authored-by: Mike Diarmid <[email protected]>
@Ehesp @Salakar
Update packages/firebase_messaging/firebase_messaging_web/pubspec.yaml
c62b462 
Co-authored-by: Mike Diarmid <[email protected]>
@Ehesp @Salakar
Update packages/firebase_messaging/firebase_messaging_web/pubspec.yaml
aeb5540 
Co-authored-by: Mike Diarmid <[email protected]>
@Ehesp @Salakar
Update packages/firebase_messaging/firebase_messaging_web/pubspec.yaml
df7418a 
Co-authored-by: Mike Diarmid <[email protected]>
@Ehesp
getToken is nullable
da00352
@Ehesp
fix analyzer warnings
0724902
@Ehesp
fix failing tests
2aa2a1f
@Salakar
Merge branch 'master' into @invertase/messaging-nnbd
83c302c
@Salakar Salakar changed the title refactor(firebase_messaging)!: nnbd migration refactor(messaging)!: migrate to NNBD Feb 2, 2021
@Salakar Salakar merged commit 8a58dac into master Feb 2, 2021
@Salakar Salakar deleted the @invertase/messaging-nnbd branch February 2, 2021 20:53
@spacejunky spacejunky mentioned this pull request Feb 4, 2021
Closed
@firebase firebase locked and limited conversation to collaborators Mar 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Salakar Salakar Salakar left review comments

@rrousselGit rrousselGit rrousselGit approved these changes

@kroikie kroikie Awaiting requested review from kroikie

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ehesp @Salakar @rrousselGit