Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(firebase_database)!: Migrate to sound null-safety #5441

Merged
merged 25 commits into from
Apr 14, 2021

Conversation

aaqibismail
Copy link
Contributor

Description

This PR updates the firebase_database package to sound null-safety.

I removed both the flutter_driver and e2e packages because they have not been updated to null-safety yet and from what I've seen the other flutterfire packages have done the same. For certain fields such as the previousSiblingsKey field in the Event class, I was unsure whether to make them nullable or not, so I opted to keep these variables nullable to be safe.

Related Issues

#5207

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@google-cla google-cla bot added the cla: yes label Mar 23, 2021
@aaqibismail aaqibismail changed the title Migrate firebase_database to sound null-safety refactor: Migrate firebase_database to sound null-safety Mar 23, 2021
@aaqibismail aaqibismail changed the title refactor: Migrate firebase_database to sound null-safety refactor(firebase_database): Migrate to sound null-safety Mar 23, 2021
This will fix the import issues in the end-to-end test files which require flutter_driver.
@b3nb5n
Copy link

b3nb5n commented Mar 23, 2021

Thank you 🙏🏻

@google-cla
Copy link

google-cla bot commented Mar 24, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Mar 24, 2021
@rrousselGit
Copy link
Contributor

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Mar 24, 2021
@Salakar
Copy link
Member

Salakar commented Mar 25, 2021

Note: version bump on the package and the changelog entry is not required so these should be reverted.

@rrousselGit
Copy link
Contributor

Could you make sure that the CI pass? thanks!

@aaqibismail
Copy link
Contributor Author

Could you make sure that the CI pass? thanks!

What should I do about the e2e package. It’s not updated to null safety so the CI is throwing an error.

@rrousselGit rrousselGit self-assigned this Apr 7, 2021
@Salakar Salakar assigned Salakar and unassigned rrousselGit Apr 14, 2021
@google-cla
Copy link

google-cla bot commented Apr 14, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Apr 14, 2021
@Salakar
Copy link
Member

Salakar commented Apr 14, 2021

Refactored tests to use drive package that other FlutterFire example apps are using. Additionally upgraded the Android example app to v2 embedding to resolve the build issues from CI tested locally;

image
image

@Salakar
Copy link
Member

Salakar commented Apr 14, 2021

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Apr 14, 2021
@Salakar Salakar changed the title refactor(firebase_database): Migrate to sound null-safety refactor(firebase_database)!: Migrate to sound null-safety Apr 14, 2021
@Salakar Salakar merged commit 13bda52 into firebase:master Apr 14, 2021
@firebase firebase locked and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants