-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(firebase_database)!: Migrate to sound null-safety #5441
refactor(firebase_database)!: Migrate to sound null-safety #5441
Conversation
This will fix the import issues in the end-to-end test files which require flutter_driver.
Thank you 🙏🏻 |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
Note: version bump on the package and the changelog entry is not required so these should be reverted. |
packages/firebase_database/example/test_driver/firebase_database_e2e_test.dart
Outdated
Show resolved
Hide resolved
Could you make sure that the CI pass? thanks! |
What should I do about the e2e package. It’s not updated to null safety so the CI is throwing an error. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
Description
This PR updates the firebase_database package to sound null-safety.
I removed both the flutter_driver and e2e packages because they have not been updated to null-safety yet and from what I've seen the other flutterfire packages have done the same. For certain fields such as the
previousSiblingsKey
field in theEvent
class, I was unsure whether to make them nullable or not, so I opted to keep these variables nullable to be safe.Related Issues
#5207
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?