Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Migrate firebase_ml_vision to sound null safety #5474

Merged
merged 25 commits into from
Apr 13, 2021

Conversation

AlexHartford
Copy link
Contributor

Description

  • Updated package to sound null-safety.
  • Updated example to sound null-safety.
  • Addressed various TODOs throughout the project.

I only have an Android emulator available to me for the next couple of weeks so it'd be good if someone could test the example project on iOS.

Related Issues

#4182

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@google-cla google-cla bot added the cla: yes label Mar 25, 2021
@AlexHartford AlexHartford changed the title Firebase ml vision null safety feat!: Migrate firebase_ml_vision to sound null safety Mar 25, 2021
@rrousselGit rrousselGit self-requested a review March 25, 2021 20:36
@Salakar Salakar added the nnbd label Mar 29, 2021
@Salakar
Copy link
Member

Salakar commented Apr 1, 2021

@AlexHartford would you mind resolving the conflicts, sorry. I took a look at doing it myself but wasn't too familiar with the changes done so didn't want to break your PR 🙃

@Salakar Salakar added the blocked: customer-response Waiting for customer response, e.g. more information was requested. label Apr 1, 2021
@AlexHartford
Copy link
Contributor Author

Handled the merge conflicts. Let me know if there's anything else you need! 😁

@google-oss-bot google-oss-bot added Needs Attention This issue needs maintainer attention. and removed blocked: customer-response Waiting for customer response, e.g. more information was requested. labels Apr 1, 2021
Copy link
Contributor

@rrousselGit rrousselGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, LGTM!

@AlexHartford
Copy link
Contributor Author

Any plans to complete the merge soon?

@Salakar Salakar merged commit 5d8f7ce into firebase:master Apr 13, 2021
@Salakar
Copy link
Member

Salakar commented Apr 14, 2021

This has now been published to pub.dev - thanks everyone.

@firebase firebase locked and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Needs Attention This issue needs maintainer attention. plugin: ml_vision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants